view: Error on missing build files #1608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-cli-v-8ywayl
When running from Auspice's root directory, this replaces an unhandled scandir error with a more meaningful message. When running from an external project, this prevents falling back to running from build files in Auspice's root directory, which is often unintentional.
victorlin
force-pushed
the
victorlin/cli-view-error-on-missing-build
branch
from
d9bbe78 to
bdfe751
Compare
nextstrain-bot
temporarily deployed
to
auspice-victorlin-cli-v-8ywayl
victorlin
commented
Dec 5, 2022
| ) { | ||
| console.log(chalk.redBright(`ERROR: Auspice build files not found under ${cwd}. Did you run \`auspice build\` in this directory?`)); |
There was a problem hiding this comment.
When running from an external project, this prevents falling back to running from build files in Auspice's root directory, which is often unintentional.
As mentioned in #1606 (comment), this behavior is actually intentional for anyone using npm install --global auspice. Thinking more on this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
When running from Auspice's root directory, this replaces an unhandled scandir error with a more meaningful message.
When running from an external project, this prevents falling back to running from build files in Auspice's root directory, which is often unintentional.
Related issue(s)
Prevents issues such as #1520 (comment) from arising.
Testing
auspice viewrm -rf dist/ && npm run startfrom Auspice root shows the new error message (checked locally)rm -rf dist/ && npm run startfrom auspice.us project root shows the new error message (checked locally)npm run build && npm run startfrom Auspice root works fine (checked locally)npm run build && npm run startfrom auspice.us project root works fine (checked locally)