Skip to content

Commit

Permalink
Remove prepare script
Browse files Browse the repository at this point in the history
The prepare script is automatically run with every call to npm ci / npm
install, among other scripts¹. As it is just an alias to the build
script (which can take several minutes), it should be safe to remove
this automation and speed up the dev experience.

Some parts of the README and CI workflow had relied on the prepare
script automation. Updated accordingly.

¹ https://docs.npmjs.com/cli/v8/using-npm/scripts?v=true#life-cycle-operation-order
  • Loading branch information
victorlin committed Dec 3, 2022
1 parent a416642 commit 35453f9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
node-version: ${{ matrix.node }}
- run: npm ci
- run: npm run get-data
- run: npm run build
- run: npm run smoke-test:ci
lint:
runs-on: ubuntu-latest
Expand All @@ -69,6 +70,7 @@ jobs:
with:
node-version: ${{ matrix.node }}
- run: npm ci
- run: npm run build
- run: npx bundlesize
publish:
if: ${{ github.ref == 'refs/heads/release' }}
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ If you wish to view the [nextstrain-maintained narratives](https://nextstrain.or
### Run auspice

```bash
auspice build --verbose
auspice view --datasetDir data
```

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"start": "npm run view",
"server": "npm run view",
"build": "node auspice.js build --verbose",
"prepare": "npm run build",
"lint": "eslint src",
"lint:fix": "eslint --fix src",
"get-data": "env bash ./scripts/get-data.sh",
Expand Down

0 comments on commit 35453f9

Please sign in to comment.