Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: ICD11 MONDO:GENERATED synonyms #749

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Jan 13, 2025

Partially addresses:

Overview

Temporarily disabled MONDO:GENERATED synonyms from being created, as there are currently some edge cases where we are creating synonyms that are not mutated as intended.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

  • Yes
  • No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

  • Yes

- Temporarily disabled MONDO:GENERATED synonyms from being created, as there are currently some edge cases where we are creating synonyms that are not mutated as intended.
Copy link
Contributor

@twhetzel twhetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but there is #756 that was generated from bugfix-icd11-generated-synonyms with some extra changes.

* icd11 specific synonym sparql query fix
* add icd11 specific query to makefile for icd11 processing
@joeflack4 joeflack4 merged commit 037b363 into develop Jan 17, 2025
@joeflack4 joeflack4 deleted the bugfix-icd11-generated-synonyms branch January 17, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants