Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTTP client and TLS parts optional for "domain model only" use #26

Merged

Conversation

ikrivosheev
Copy link
Contributor

@michaelklishin hello! Thank you for the library! It's cool. Here is some changes:

  1. Made reqwest as option change. My use case is: using from the library only models.
  2. Created ClientBuilder for build custom Client
  3. Removed from library everything about tls. You can configure this with ClientBuilder from reqwest
  4. Removed create client for every request.

@michaelklishin michaelklishin changed the title Some fixes Make HTTP client and TLS parts optional for "domain model only" use Oct 17, 2024
@michaelklishin
Copy link
Owner

@michaelklishin michaelklishin merged commit 8d50789 into michaelklishin:main Oct 18, 2024
2 checks passed
@michaelklishin
Copy link
Owner

@ikrivosheev thank you! I'm looking forward to the async HTTP client version you have in mind :)

@ikrivosheev ikrivosheev deleted the feature/client_builder branch October 18, 2024 18:59
@ikrivosheev
Copy link
Contributor Author

@ikrivosheev thank you! I'm looking forward to the async HTTP client version you have in mind :)

Thank you! I'm working on it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants