Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async interface #27

Closed
ikrivosheev opened this issue Oct 17, 2024 · 3 comments · Fixed by #30
Closed

Support async interface #27

ikrivosheev opened this issue Oct 17, 2024 · 3 comments · Fixed by #30
Milestone

Comments

@ikrivosheev
Copy link
Contributor

Hello! Thank you for the great library! I want to add async interface. Is it ok?

@michaelklishin
Copy link
Owner

@ikrivosheev I cannot comment on such a terse problem definition.

The biggest headache around supporting an async API is the dependencies. So it will have to be an opt-in feature using, for example, some Tokio bits.

Otherwise I have no objections, we have HTTP API clients that support two versions and it was the goal with the namespacing used here.

@michaelklishin
Copy link
Owner

I see that in #26, even the blocking client becomes optional. In which case making the dependency-heavy async one optional is probably what you had in mind anyway.

@ikrivosheev
Copy link
Contributor Author

I see that in #26, even the blocking client becomes optional. In which case making the dependency-heavy async one optional is probably what you had in mind anyway.

Yes, you are right. I meant async client would be optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants