Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactored blocking client #29

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: Refactored blocking client #29

merged 1 commit into from
Oct 22, 2024

Conversation

ikrivosheev
Copy link
Contributor

@michaelklishin hello! This is continue: #26

  1. Add a macros for build path
  2. Replaced u16 to StatusCode
  3. Moved call ok_or_status_code_error in http_* methods

@ikrivosheev ikrivosheev mentioned this pull request Oct 22, 2024
Merged
@michaelklishin
Copy link
Owner

The virtual_host parameter name seems perfectly fine to me but I don't feel strongly about this, vhost is not going to surprise anyone.

@michaelklishin michaelklishin merged commit f58f151 into michaelklishin:main Oct 22, 2024
2 checks passed
@ikrivosheev
Copy link
Contributor Author

The virtual_host parameter name seems perfectly fine to me but I don't feel strongly about this, vhost is not going to surprise anyone.

I wanted to make consistently with other part of the library

@ikrivosheev ikrivosheev deleted the feature/refactor branch October 22, 2024 17:47
@michaelklishin michaelklishin added this to the 0.9.0 milestone Oct 23, 2024
michaelklishin added a commit that referenced this pull request Nov 22, 2024
@michaelklishin
Do not assume that HTTP API prefix is always "api"
b163086 
It can be overridden and management plugin's own
test suite runs most tests both with the default
and an overridden prefix.

References #29, #30, #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ikrivosheev @michaelklishin