Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl #203 - retrieve asset details from DLCS when responding to Create Manifest #240

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Impl #203 - retrieve asset details from DLCS when responding to Create Manifest #240

wants to merge 5 commits into from
+255 −41

Conversation

p-kaczynski
Copy link
Contributor

@p-kaczynski p-kaczynski commented Jan 20, 2025 •
edited
Loading

#203

  • Add ReadAsJson helper to handle not-deserialised responses from DLCS
  • Add GetBatchAssets call to DLCS client
  • Add ability to use provided asset dictionary during canvas painting supplementation in manifest create
  • Code cleanup
  • Test + fix for asset detail in manifest creation response

@p-kaczynski p-kaczynski linked an issue Jan 21, 2025 that may be closed by this pull request
Returning full Asset in Manifest response #203
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldgray donaldgray Awaiting requested review from donaldgray

@JackLewis-digirati JackLewis-digirati Awaiting requested review from JackLewis-digirati

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returning full Asset in Manifest response
1 participant
@p-kaczynski