Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning full Asset in Manifest response #203

Open
donaldgray opened this issue Dec 6, 2024 · 1 comment · May be fixed by #240
Open

Returning full Asset in Manifest response #203

donaldgray opened this issue Dec 6, 2024 · 1 comment · May be fixed by #240
Assignees

Comments

@donaldgray
Copy link
Member

Follow on from #173 (which is returning the asset-id only) this ticket is to flesh out the returned asset result to include the full DLCS asset.

To do this call /allImages, specifying the ids of the assets contained in the manifest. Note that /allImages has a maximum number of ids so we may need to make multiple requests.

These should be returned in the same order as they are in the canvas_paintings table.

If an asset could not be found, return a "placeholder" asset in the result set, with just an "id" and "error"

@donaldgray donaldgray changed the title Returning full Asset in response Returning full Asset in Manifest response Dec 6, 2024
@donaldgray
Copy link
Member Author

Note - this ticket mentions using /allImages to get details of all assets. dlcs/protagonist#932 introduced a new endpoint where all assets could be fetched for a batch, which is a possibility.

Consider trade off of number of calls to be made, size of payloads etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants