-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the registry stack PR review process #384
Conversation
WIP Because:
|
The above blockers were resolved, removed the WIP label |
You might need to force push the sign off for the commits to clear DCO @thepetk |
Yeap :) I want to make small update to the CODEOWNERS file so I'll fix it once I push my new commits |
f158d0e
to
ee26576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ibuziuk is adding a new ollama stack that will need the OWNERS
file refactored as well: #387
Since that PR needs merging by the weeks end, I'd suggest we wait for that change then refactor that OWNERS
file into CODEOWNERS
here, that way we don't need an extra PR and it still should be completed by sprints end. @thepetk wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, should include someone from team che to approve as well.
I've already requested review from @ibuziuk :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@michael-valdron as you have requested changes in the past, could you review the updated version of the PR? |
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
SIgned-off-by: thepetk <[email protected]> Signed-off-by: thepetk <[email protected]>
9e550e6
to
cde5608
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to merge
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmytro-ndp, ibuziuk, Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
This PR updates the contributing guide, adding a section to describe the process followed by the devfiles team regarding the review of PRs updating stacks content.
Other than the contributing guide, it removes all OWNERS files and moves all related information inside the
.github/CODEOWNERS
file.Which issue(s) this PR fixes:
fixes devfile/api#1498
fixes devfile/api#1525
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: