Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS (remove myself) #385

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented May 7, 2024

Thanks for adding me some years ago to review changes to the devfile registry. But I don't think I can help here regularly, and I never had.

I would be happy if the bot stopped requesting reviews from my side. Feel free to ping me in special cases on Slack or here, but I need to reduce notifications on GitHub a bit.

@openshift-ci openshift-ci bot requested review from kim-tsao and maysunfaisal May 7, 2024 10:08
@christoph-jerolimov
Copy link
Member Author

/cc @elsony

@openshift-ci openshift-ci bot requested a review from elsony May 7, 2024 10:17
@thepetk
Copy link
Contributor

thepetk commented May 7, 2024

FYI there's PR already open to update the logic around OWNERS files and replace them with the CODEOWNERS

here: #384

Signed-off-by: Christoph Jerolimov <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Looks good to me label May 8, 2024
@christoph-jerolimov
Copy link
Member Author

/approve

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibuziuk, jerolimov, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 8, 2024
@michael-valdron
Copy link
Member

@jerolimov Do you have permissions to merge or need help merging?

@christoph-jerolimov
Copy link
Member Author

christoph-jerolimov commented May 9, 2024

@michael-valdron I have no permissions to merge it. I thought the bot will do it, but it would be nice if you can help to merge this mini pr ;)

Thanks

@thepetk thepetk merged commit e69218b into devfile:main May 9, 2024
10 checks passed
@christoph-jerolimov christoph-jerolimov deleted the patch-1 branch May 10, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants