Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ollama devfile #387

Merged
merged 1 commit into from
May 10, 2024
Merged

Adding Ollama devfile #387

merged 1 commit into from
May 10, 2024

Conversation

ibuziuk
Copy link
Collaborator

@ibuziuk ibuziuk commented May 8, 2024

What does this PR do?:

Adding Ollama devfile

Inspired by https://www.opensourcerers.org/2023/11/06/a-personal-ai-assistant-for-developers-that-doesnt-phone-home/

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/CRW-6049

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

https://workspaces.openshift.com#https://raw.githubusercontent.com/devfile/registry/b0af3873840501ae8732c997bc528dfcb011c879/stacks/ollama/devfile.yaml

@ibuziuk
Copy link
Collaborator Author

ibuziuk commented May 9, 2024

/verify-owners

stacks/ollama/OWNERS Outdated Show resolved Hide resolved
stacks/ollama/devfile.yaml Outdated Show resolved Hide resolved
stacks/ollama/devfile.yaml Outdated Show resolved Hide resolved
Signed-off-by: Ilya Buziuk <[email protected]>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label May 9, 2024
Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibuziuk, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 9, 2024
@ibuziuk ibuziuk merged commit 2301fb0 into main May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants