Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching off reconstruction of so called "NullTaus" #17706

Closed

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Mar 2, 2017

Hi all,

this is a simple configuration switch to remove the so called "null-taus" from the tau reconstruction. Null taus are jets seeding tau candidates, which actually do not fulfil any good tau reconstruction criterion. In the past these had been kept in the reconstruction for debugging purposes, since it allows a 1:1 correspondence of reconstructed tau candidates with seeding jets. In the meantime this should be switched to False when running in standard reconstruction. For more details refer to @mbluj.

NB:
we have split this change off from #17620 for clarity reasons. See also discussion in the conversation there.

Cheers,
Roger
Automatically ported from CMSSW_9_0_X #17643 (original by @cms-tau-pog).
Please wait for a new IB (12 to 24H) before requesting to test this PR.

roger-wolf and others added 4 commits February 24, 2017 12:50
Add an additional requirement that PFChargedHardon exists. It protects against poor taus build around RecoTauChargedHadron candidates with a poor track which usually have null or very small momentum.
@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

RecoTauTag/Configuration
RecoTauTag/RecoTau

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 2, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18061/console Started: 2017/03/02 15:31
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18112/console Started: 2017/03/03 03:22

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017

Pull request #17706 was updated. @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 2, 2017

@mbluj
your last commits introduced conflicts
please rebase

@mbluj
Copy link
Contributor

mbluj commented Mar 2, 2017

Yes, sorry, I pushed to incorrect repository. It will be solved tomorrow as I have to leave now. Anyway, it is not urgent as this goes to 91X anyway.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

-1
@cmsbuild This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17706/18112/git-merge-result

@mbluj
Copy link
Contributor

mbluj commented Mar 3, 2017

Closing as mentioned in #17767

Michał

@slava77
Copy link
Contributor

slava77 commented Mar 6, 2017

-1
this is supposed to be closed based on comments in #17706 (comment)

@davidlange6 davidlange6 closed this Mar 7, 2017
@roger-wolf roger-wolf deleted the CMSSW_9_0_X_tau-pog-removeNullTaus branch November 17, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants