-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching off reconstruction of so called "NullTaus" #17767
Switching off reconstruction of so called "NullTaus" #17767
Conversation
Add an additional requirement that PFChargedHardon exists. It protects against poor taus build around RecoTauChargedHadron candidates with a poor track which usually have null or very small momentum.
A new Pull Request was created by @mbluj for master. It involves the following packages: RecoTauTag/RecoTau @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
@davidlange6 |
err- thats a good question. I think I clicked on the wrong PR. Shall i unmerge it? |
@davidlange6 |
@mbluj @roger-wolf Are these plots missing a basic tau quality preselection or did this update remove more than necessary? |
Yes, this plot is done without checking if a tau candidate passes basic quality criteria as presence of leading track. Differences are expected: it should be less tau candidates with low values of isolation sum. |
On 3/14/17 9:38 AM, mbluj wrote:
Yes, this plot is done without checking if a tau candidate passes basic
quality criteria as presence of leading track. Differences are expected:
it should be less tau candidates with low values of isolation sum.
something to put on the list to fix in DQM at some point?
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17767 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbr7hnRWlSq80vYmem93AGtbZy_Olks5rlsKCgaJpZM4MSS9f>.
|
> Yes, this plot is done without checking if a tau candidate passes basic
> quality criteria as presence of leading track. Differences are expected:
> it should be less tau candidates with low values of isolation sum.
something to put on the list to fix in DQM at some point?
Yes, right we should think on fixing DQM to not look on very poor taus.
But, such poor taus will not be produced when this PR is merged, so DQM
will not see them.
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
Hi All,
it is a copy of #17706 rebased to the main branch (91X). Description of the original RP cited below for reference. The #17706 will be closed in a minute.
Best,
Michał
Hi all,
this is a simple configuration switch to remove the so called "null-taus" from the tau reconstruction. Null taus are jets seeding tau candidates, which actually do not fulfill any good tau reconstruction criterion. In the past these had been kept in the reconstruction for debugging purposes, since it allows a 1:1 correspondence of reconstructed tau candidates with seeding jets. In the meantime this should be switched to False when running in standard reconstruction. For more details refer to @mbluj.
NB:
we have split this change off from #17620 (90X) for clarity reasons. See also discussion in the conversation there.
Cheers,
Roger