Switching off reconstruction of so called "NullTaus" #17643

roger-wolf · 2017-02-27T16:19:35Z

Hi all,

this is a simple configuration switch to remove the so called "null-taus" from the tau reconstruction. Null taus are jets seeding tau candidates, which actually do not fulfil any good tau reconstruction criterion. In the past these had been kept in the reconstruction for debugging purposes, since it allows a 1:1 correspondence of reconstructed tau candidates with seeding jets. In the meantime this should be switched to False when running in standard reconstruction. For more details refer to @mbluj.

NB:
we have split this change off from #17620 for clarity reasons. See also discussion in the conversation there.

Cheers,
Roger

…ect on losely seleced taus

cmsbuild · 2017-02-27T16:19:54Z

A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_9_0_X.

It involves the following packages:

RecoTauTag/Configuration
RecoTauTag/RecoTau

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

slava77 · 2017-02-27T16:21:43Z

@cmsbuild please test

cmsbuild · 2017-02-27T16:22:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17991/console Started: 2017/02/27 17:22

Add an additional requirement that PFChargedHardon exists. It protects against poor taus build around RecoTauChargedHadron candidates with a poor track which usually have null or very small momentum.

cmsbuild · 2017-02-27T17:34:30Z

Pull request #17643 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2017-02-27T17:45:36Z

-1

Tested at: 2f5c59c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17643/17991/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Mon Feb 27 18:25:34 2017-date Mon Feb 27 18:16:18 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02461/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Feb 27 18:25:34 2017-date Mon Feb 27 18:16:18 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Mon Feb 27 18:25:34 2017-date Mon Feb 27 18:16:18 2017 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02461/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-26-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Mon Feb 27 18:33:01 2017-date Mon Feb 27 18:25:35 2017 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Mon Feb 27 18:37:21 2017-date Mon Feb 27 18:27:19 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02461/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-26-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Feb 27 18:37:21 2017-date Mon Feb 27 18:27:19 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Mon Feb 27 18:37:21 2017-date Mon Feb 27 18:27:19 2017 s - exit: 21504

cmsbuild · 2017-02-27T17:45:39Z

Comparison job queued.

mbluj · 2017-02-27T18:02:28Z

Hi,
it is added an additional selection at output of tau producer to remove tau candidates without a real leading PFChargedHadronCandidate. In some taus it can substituted by a neutral PFCandidate matched to rather poor general track not used by PFlow which produces a tau candidate with a null or small momentum. Tau candidates removed by this selection do not pass tau-decay mode reconstruction required at analysis level.
Fixes slava77#99

slava77 · 2017-02-27T18:22:18Z

@cmsbuild please test

the addOn test failure appears to be due to (intermittent?) file IO issues

cmsbuild · 2017-02-27T18:22:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17994/console Started: 2017/02/27 19:23

cmsbuild · 2017-02-27T20:13:22Z

+1
Tested at: ebc448c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17643/17994/summary.html

cmsbuild · 2017-02-27T20:13:25Z

Comparison job queued.

cmsbuild · 2017-02-27T22:35:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17643/17994/summary.html

…pog-removeNullTaus

cmsbuild · 2017-03-01T17:27:25Z

Pull request #17643 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

slava77 · 2017-03-01T17:35:28Z

@cmsbuild please test

cmsbuild · 2017-03-01T17:35:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18036/console Started: 2017/03/01 18:36

cmsbuild · 2017-03-01T18:47:01Z

+1
Tested at: b6cb375
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17643/18036/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b6cb375
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17643/18036/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17643/18036/git-merge-result

cmsbuild · 2017-03-01T18:47:04Z

Comparison job queued.

cmsbuild · 2017-03-01T20:21:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17643/18036/summary.html

slava77 · 2017-03-02T14:23:36Z

-1
superseded by #17706
90X is closed for new feautres: this is a new feature, despite of it been somewhat technical

roger-wolf added 3 commits February 23, 2017 01:18

update of test files

2b2d331

Merge branch 'from-CMSSW_9_0_X_2017-02-22-2300' into CMSSW_9_0_X_tau-pog

dd670c7

switching so called null-tau creation -- we expect a less than 5% eff…

2f5c59c

…ect on losely seleced taus

cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 27, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Feb 27, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 27, 2017

Update RecoTauCombinatoricProducer_cfi.py

ebc448c

Add an additional requirement that PFChargedHardon exists. It protects against poor taus build around RecoTauChargedHadron candidates with a poor track which usually have null or very small momentum.

cmsbuild added tests-pending and removed tests-started labels Feb 27, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 27, 2017

cmsbuild added tests-approved and removed tests-started labels Feb 27, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 27, 2017

Merge branch 'from-CMSSW_9_0_X_2017-02-26-2300' into CMSSW_9_0_X_tau-…

b6cb375

…pog-removeNullTaus

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Mar 1, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 1, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 1, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 1, 2017

cmsbuild mentioned this pull request Mar 2, 2017

Switching off reconstruction of so called "NullTaus" #17706

Closed

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Mar 2, 2017

davidlange6 closed this Mar 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switching off reconstruction of so called "NullTaus" #17643

Switching off reconstruction of so called "NullTaus" #17643

roger-wolf commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

slava77 commented Feb 27, 2017

cmsbuild commented Feb 27, 2017 •

edited

Loading

cmsbuild commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

mbluj commented Feb 27, 2017 •

edited

Loading

slava77 commented Feb 27, 2017

cmsbuild commented Feb 27, 2017 •

edited

Loading

cmsbuild commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

cmsbuild commented Mar 1, 2017

slava77 commented Mar 1, 2017

cmsbuild commented Mar 1, 2017 •

edited

Loading

cmsbuild commented Mar 1, 2017

cmsbuild commented Mar 1, 2017

cmsbuild commented Mar 1, 2017

slava77 commented Mar 2, 2017

Switching off reconstruction of so called "NullTaus" #17643

Switching off reconstruction of so called "NullTaus" #17643

Conversation

roger-wolf commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

slava77 commented Feb 27, 2017

cmsbuild commented Feb 27, 2017 • edited Loading

cmsbuild commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

mbluj commented Feb 27, 2017 • edited Loading

slava77 commented Feb 27, 2017

cmsbuild commented Feb 27, 2017 • edited Loading

cmsbuild commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

cmsbuild commented Feb 27, 2017

cmsbuild commented Mar 1, 2017

slava77 commented Mar 1, 2017

cmsbuild commented Mar 1, 2017 • edited Loading

cmsbuild commented Mar 1, 2017

cmsbuild commented Mar 1, 2017

cmsbuild commented Mar 1, 2017

slava77 commented Mar 2, 2017

cmsbuild commented Feb 27, 2017 •

edited

Loading

mbluj commented Feb 27, 2017 •

edited

Loading

cmsbuild commented Feb 27, 2017 •

edited

Loading

cmsbuild commented Mar 1, 2017 •

edited

Loading