refactor(perception/lidar_apollo_instance_segmentation): rework parameters #5739

karishma1911 · 2023-12-01T05:57:12Z

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the perception_apollo_instance_segmentation

Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.

2.create schema

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

yukke42

I confirmed it works.

codecov · 2023-12-13T15:31:37Z

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 15.31%. Comparing base (3d849e9) to head (3a62ceb).
Report is 346 commits behind head on main.

❗ Current head 3a62ceb differs from pull request most recent head d977878

Please upload reports for the commit d977878 to get more accurate results.

Files	Patch %	Lines
...idar_apollo_instance_segmentation/src/detector.cpp	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5739      +/-   ##
==========================================
+ Coverage   15.09%   15.31%   +0.21%     
==========================================
  Files        1967     1765     -202     
  Lines      135941   119466   -16475     
  Branches    42122    35967    -6155     
==========================================
- Hits        20520    18295    -2225     
+ Misses      92700    80716   -11984     
+ Partials    22721    20455    -2266

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`15.37% <ø> (+0.28%)`	⬆️	Carriedforward from 05c6d82

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

perception/lidar_apollo_instance_segmentation/schema/lidar_apollo_instance_segmentation.json

stale · 2024-03-20T03:22:32Z

This pull request has been automatically marked as stale because it has not had recent activity.

idorobotics · 2024-05-24T09:40:18Z

@yukkysaito @miursh please review and merge?

xmfcx · 2024-05-24T11:28:24Z

@karishma1911 could you rebase this to the latest main? To fix the CI.

Or click Allow edits and access to secrets by maintainers. For this PR. So we can do it for you.

…ndation#5744) Signed-off-by: Takagi, Isamu <[email protected]>

…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <[email protected]> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>

…warefoundation#5689) fix(avoidance): output invalid avoidance path Signed-off-by: satoshi-ota <[email protected]>

Signed-off-by: GitHub <[email protected]> Co-authored-by: github-actions <[email protected]>

…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <[email protected]>

…oid exceeding max voxel size (autowarefoundation#5824)

…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <[email protected]>

…arefoundation#5819) * fix(traffic_light): stop if the traffic light signal timed out Signed-off-by: Fumiya Watanabe <[email protected]> * fix(traffic_light): fix README format Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>

…c_time/elapsed_time, tentative objects (autowarefoundation#5762) * enable debugger in tracker Signed-off-by: yoshiri <[email protected]> * fix uninitialized class variable Signed-off-by: yoshiri <[email protected]> * feat: separate debugger class for simplification Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>

…utowarefoundation#5830) Signed-off-by: Zulfaqar Azmi <[email protected]>

…utowarefoundation#6099) Signed-off-by: satoshi-ota <[email protected]>

…refoundation#6087) Signed-off-by: kosuke55 <[email protected]>

…affic light id map every callback (autowarefoundation#6061) Signed-off-by: Mamoru Sobue <[email protected]>

…compensation (autowarefoundation#6080) Signed-off-by: scepter914 <[email protected]>

* fix(pointpainting): fix param path declaration Signed-off-by: kminoda <[email protected]> * remove pointpainting_model_name Signed-off-by: kminoda <[email protected]> * revert: revert unnecessary change Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]>

* docs(crosswalk): update the document Signed-off-by: Takayuki Murooka <[email protected]> * fix the spell Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>

…usion detection and 1st/2nd attention lane (autowarefoundation#6047) Signed-off-by: Mamoru Sobue <[email protected]>

…utowarefoundation#5635) Signed-off-by: Mamoru Sobue <[email protected]>

Signed-off-by: kosuke55 <[email protected]> remove non-support Signed-off-by: kosuke55 <[email protected]> fix link Signed-off-by: kosuke55 <[email protected]> add yaml Signed-off-by: kosuke55 <[email protected]> please check readme

Signed-off-by: GitHub <[email protected]> Co-authored-by: github-actions <[email protected]>

…on#6103) * Visualize the footprint from start_pose to end_pose along the path Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>

…data structure (autowarefoundation#6101) * Add data_structs.hpp and update include paths * Refactor start planner debug data structure * Update debug_data variable name in StartPlannerModule Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <[email protected]>

…pty (autowarefoundation#6104) * check if p_safety_slow is empty Signed-off-by: beyza <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: beyza <[email protected]> Co-authored-by: beyza <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…utowarefoundation#6091) * feat!: replace use_pointcloud_container Signed-off-by: kminoda <[email protected]> * feat: remove from planning Signed-off-by: kminoda <[email protected]> * fix: fix to remove all use_pointcloud_container Signed-off-by: kminoda <[email protected]> * revert: revert change in planning.launch Signed-off-by: kminoda <[email protected]> * revert: revert rename of use_pointcloud_container Signed-off-by: kminoda <[email protected]> * fix: fix tier4_perception_launch to enable use_pointcloud_contaienr Signed-off-by: kminoda <[email protected]> * fix: fix unnecessary change Signed-off-by: kminoda <[email protected]> * fix: fix unnecessary change Signed-off-by: kminoda <[email protected]> * refactor: remove trailing whitespace Signed-off-by: kminoda <[email protected]> * revert other changes in perception Signed-off-by: kminoda <[email protected]> * revert change in readme Signed-off-by: kminoda <[email protected]> * feat: move glog to pointcloud_container.launch.py * revert: revert glog porting Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix: fix pre-commit Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…ion (autowarefoundation#6072) * add acc filtering and decaying acc to model Signed-off-by: Daniel Sanchez <[email protected]> * fixed compilation problem, acc is used to predict search_dist Signed-off-by: Daniel Sanchez <[email protected]> * Use an equivalent velocity to calculate paths Signed-off-by: Daniel Sanchez <[email protected]> * change decaying factor to T/4 Signed-off-by: Daniel Sanchez <[email protected]> * coment out cerr for evaluation Signed-off-by: Daniel Sanchez <[email protected]> * simplify code Signed-off-by: Daniel Sanchez <[email protected]> * comments Signed-off-by: Daniel Sanchez <[email protected]> * add missing constant to decaying acc model Signed-off-by: Daniel Sanchez <[email protected]> * Use an equivalent velocity to calculate paths Signed-off-by: Daniel Sanchez <[email protected]> * add missing constant to decaying acc model Signed-off-by: Daniel Sanchez <[email protected]> * Implement lanelet speed limit for acc consideration Signed-off-by: Daniel Sanchez <[email protected]> * add option to activate on and off acceleration feature Signed-off-by: Daniel Sanchez <[email protected]> * add params Signed-off-by: Daniel Sanchez <[email protected]> * add params Signed-off-by: Daniel Sanchez <[email protected]> * delete unused class Signed-off-by: Daniel Sanchez <[email protected]> * update docs Signed-off-by: Daniel Sanchez <[email protected]> * delete comments Signed-off-by: Daniel Sanchez <[email protected]> * fix comments Signed-off-by: Daniel Sanchez <[email protected]> * update comments, refactor code Signed-off-by: Daniel Sanchez <[email protected]> * remove unused line Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]> Signed-off-by: Daniel Sanchez <[email protected]>

…om/Interplai/autoware.universe into lidar-apollo-instance-segmentation

yukkysaito

LGTM
cc @kminoda

idorobotics · 2024-06-13T17:28:56Z

LGTM cc @kminoda

Thanks!

miursh · 2024-06-14T01:34:44Z

@idorobotics
Could you please merge main branch to your branch again? In order to pass DCO check.

idorobotics · 2024-06-14T16:42:38Z

@idorobotics
Could you please merge main branch to your branch again? In order to pass DCO check.

@karishma1911

kminoda · 2024-06-24T00:24:57Z

@karishma1911 Hi, thank you for your contribution!
To maintain the opened PR in Autoware Universe, let me close this PR for now 🙏
We are happy to review it again after the PR is fixed.

Thank you for your understanding.

karishma1911 requested a review from yukkysaito as a code owner December 1, 2023 05:57

github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 1, 2023

karishma1911 force-pushed the lidar-apollo-instance-segmentation branch from 583022d to 02eaecc Compare December 1, 2023 05:58

yukkysaito requested review from yukke42 and miursh December 4, 2023 02:13

yukke42 approved these changes Dec 6, 2023

View reviewed changes

karishma1911 force-pushed the lidar-apollo-instance-segmentation branch from 0989feb to 50ee349 Compare December 6, 2023 11:22

miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 13, 2023

miursh enabled auto-merge (squash) December 13, 2023 15:26

miursh disabled auto-merge December 13, 2023 15:27

karishma1911 force-pushed the lidar-apollo-instance-segmentation branch 2 times, most recently from 9785e57 to b2f5cfb Compare December 14, 2023 08:03

miursh reviewed Dec 14, 2023

View reviewed changes

perception/lidar_apollo_instance_segmentation/schema/lidar_apollo_instance_segmentation.json Show resolved Hide resolved

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 20, 2024

xmfcx assigned karishma1911 May 24, 2024

stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 24, 2024

isamu-takagi and others added 10 commits May 26, 2024 12:59

fix(autoware_auto_msgs_adapter): fix predicted path test (autowarefou…

1867e8b

…ndation#5744) Signed-off-by: Takagi, Isamu <[email protected]>

fix(avoidance): output invalid avoidance path with unsafe state (auto…

3c65061

…warefoundation#5689) fix(avoidance): output invalid avoidance path Signed-off-by: satoshi-ota <[email protected]>

chore: update CODEOWNERS (autowarefoundation#5811)

0632078

Signed-off-by: GitHub <[email protected]> Co-authored-by: github-actions <[email protected]>

fix(localization_util): fixed rejection criteria of SmartPoseBuffer::…

a42031b

…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <[email protected]>

fix(lidar_centerpoint,image_projection_based_fusion): add guard to av…

aeb55d0

…oid exceeding max voxel size (autowarefoundation#5824)

feat(obstacle_cruise_planner): add jerk and acc limits for slow-down (a…

e89fc75

…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <[email protected]>

refactor(surround_obstacle_checker): boost::optional to std:optional (a…

44860b6

…utowarefoundation#5830) Signed-off-by: Zulfaqar Azmi <[email protected]>

satoshi-ota and others added 19 commits May 26, 2024 12:59

feat(behavior_path_planner): output manager internal state as topic (a…

f35dc81

…utowarefoundation#6099) Signed-off-by: satoshi-ota <[email protected]>

refactor(goal_planner): remove duplicated execution condition (autowa…

fffcd81

…refoundation#6087) Signed-off-by: kosuke55 <[email protected]>

fix(behavior_velocity_planner, behavior_path_planner): refresh raw tr…

08ad628

…affic light id map every callback (autowarefoundation#6061) Signed-off-by: Mamoru Sobue <[email protected]>

fix(radar_tracks_msgs_converter): change default parameter for twist …

6748a01

…compensation (autowarefoundation#6080) Signed-off-by: scepter914 <[email protected]>

docs(crosswalk): update the document (autowarefoundation#5583)

7e3b712

* docs(crosswalk): update the document Signed-off-by: Takayuki Murooka <[email protected]> * fix the spell Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>

feat(intersection): more precise pass judge handling considering occl…

cb30746

…usion detection and 1st/2nd attention lane (autowarefoundation#6047) Signed-off-by: Mamoru Sobue <[email protected]>

feat(blind_spot): consider opposite adjacent lane for wrong vehicles (a…

c74fe48

…utowarefoundation#5635) Signed-off-by: Mamoru Sobue <[email protected]>

chore: update CODEOWNERS (autowarefoundation#6038)

b75027f

Signed-off-by: GitHub <[email protected]> Co-authored-by: github-actions <[email protected]>

refactor(start_planner): visualize shifting section (autowarefoundati…

43f7742

…on#6103) * Visualize the footprint from start_pose to end_pose along the path Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>

fix(start_planner): expand lane departure check for shift path (autow…

3bf4c26

…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <[email protected]>

perception/lidar_apollo_instance_segmentation

908377f

Merge branch 'lidar-apollo-instance-segmentation' of https://github.c…

2b9f8a1

…om/Interplai/autoware.universe into lidar-apollo-instance-segmentation

Merge branch 'main' into lidar-apollo-instance-segmentation

d977878

yukkysaito approved these changes May 28, 2024

View reviewed changes

idorobotics requested a review from yukkysaito June 13, 2024 17:27

xmfcx closed this Jun 14, 2024

xmfcx reopened this Jun 14, 2024

miursh mentioned this pull request Jun 21, 2024

Merge branch 'main' into lidar-apollo-instance-segmentation Interplai/autoware.universe#1

Closed

kminoda marked this pull request as draft June 24, 2024 00:25

kminoda closed this Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(perception/lidar_apollo_instance_segmentation): rework parameters #5739

refactor(perception/lidar_apollo_instance_segmentation): rework parameters #5739

karishma1911 commented Dec 1, 2023 •

edited

Loading

yukke42 left a comment

codecov bot commented Dec 13, 2023 •

edited

Loading

stale bot commented Mar 20, 2024

idorobotics commented May 24, 2024 •

edited

Loading

xmfcx commented May 24, 2024

yukkysaito left a comment

idorobotics commented Jun 13, 2024

miursh commented Jun 14, 2024

idorobotics commented Jun 14, 2024

kminoda commented Jun 24, 2024 •

edited

Loading

refactor(perception/lidar_apollo_instance_segmentation): rework parameters #5739

refactor(perception/lidar_apollo_instance_segmentation): rework parameters #5739

Conversation

karishma1911 commented Dec 1, 2023 • edited Loading

Description

Tests performed

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

yukke42 left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 13, 2023 • edited Loading

Codecov Report

stale bot commented Mar 20, 2024

idorobotics commented May 24, 2024 • edited Loading

xmfcx commented May 24, 2024

yukkysaito left a comment

Choose a reason for hiding this comment

idorobotics commented Jun 13, 2024

miursh commented Jun 14, 2024

idorobotics commented Jun 14, 2024

kminoda commented Jun 24, 2024 • edited Loading

karishma1911 commented Dec 1, 2023 •

edited

Loading

codecov bot commented Dec 13, 2023 •

edited

Loading

idorobotics commented May 24, 2024 •

edited

Loading

kminoda commented Jun 24, 2024 •

edited

Loading