-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove internal gitlab #3297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @olevski! It will feel good to not be responsible for this anymore :)
@olevski can we refresh this and get it merged? |
01b058f
to
5aa1251
Compare
011f2ab
to
63adb08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot approve this because I opened the PR. But I looked through the changes and everything looks good.
based on the old old version of things
You can access the deployment of this PR at https://ci-renku-3297.dev.renku.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good.
For completeness I would also add to the file helm-chart/values.yaml.changelog.md
the deletion of the corresponding values and re-iterating that the embedded Gitlab is gone.
7502cda
to
ee8bbeb
Compare
63adb08
to
8b8d779
Compare
@aledegano I added the blurb |
84de292
to
43ca1f5
Compare
Co-authored-by: Rok Roškar <[email protected]>
* chore: create release 0.62.0 * chore: update redis helm chart to latest revision (#3843) * feat: remove internal gitlab (#3297) Co-authored-by: Rok Roškar <[email protected]> * Update search to release 0.7.0 (#3852) * fix: point redis helm chart to the oci URI (#3855) * tests: remove check of project container for anonymous users (#3853) * feat: add support for session secrets in Renku 2.0 (#3837) Closes #3832. Add support for session secret slots and session secrets in Renku 2.0. --------- Co-authored-by: Tasko Olevski <[email protected]> * chore: add note about polybox/switchdrive to the top changelog (#3856) * feat: update user and group pages design (#3857) Co-authored-by: Flora Thiebaut <[email protected]> * Update CHANGELOG.rst * Update CHANGELOG.rst --------- Co-authored-by: Lionel Sambuc <[email protected]> Co-authored-by: Tasko Olevski <[email protected]> Co-authored-by: Rok Roškar <[email protected]> Co-authored-by: eikek <[email protected]> Co-authored-by: Andrea Cordoba <[email protected]> Co-authored-by: Flora Thiebaut <[email protected]> Co-authored-by: Tasko Olevski <[email protected]> Co-authored-by: Rok Roškar <[email protected]> Co-authored-by: Ralf Grubenmann <[email protected]>
This removes the omnibus gitlab helm deployment that is part of Renku.
We mentioned in our docs that we would deprecate this in the future. I think we should really get rid of it because the more we keep it around the more likely it is that someone will start running with it and then be stuck with the same migration problems that we had to go through.
The easiest/most simple demo of Renku should be done against gitlab.com or any other existing gitlab deployment. Deploying gitlab is NOT a simple thing. And combining that with rolling out Renku in one step is just too daunting.
We also really do not update/maintain/test the Gitlab helm chart. So we run the risk of someone deploying it and having problems or security issues because the helm chart is not up to date.
/deploy