Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove internal gitlab #3297

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Conversation

olevski
Copy link
Member

@olevski olevski commented Oct 9, 2023

This removes the omnibus gitlab helm deployment that is part of Renku.

We mentioned in our docs that we would deprecate this in the future. I think we should really get rid of it because the more we keep it around the more likely it is that someone will start running with it and then be stuck with the same migration problems that we had to go through.

The easiest/most simple demo of Renku should be done against gitlab.com or any other existing gitlab deployment. Deploying gitlab is NOT a simple thing. And combining that with rolling out Renku in one step is just too daunting.

We also really do not update/maintain/test the Gitlab helm chart. So we run the risk of someone deploying it and having problems or security issues because the helm chart is not up to date.

/deploy

@olevski olevski requested review from a team as code owners October 9, 2023 19:40
@olevski olevski temporarily deployed to ci-renku-3297 October 9, 2023 19:40 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3297 October 9, 2023 20:22 — with GitHub Actions Inactive
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @olevski! It will feel good to not be responsible for this anymore :)

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
scripts/generate-values/base-renku-values.yaml.template Outdated Show resolved Hide resolved
scripts/generate-values/base-renku-values.yaml.template Outdated Show resolved Hide resolved
@olevski olevski temporarily deployed to ci-renku-3297 October 31, 2023 20:12 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3297 October 31, 2023 20:16 — with GitHub Actions Inactive
@olevski olevski requested a review from rokroskar October 31, 2023 20:21
@olevski olevski temporarily deployed to ci-renku-3297 October 31, 2023 20:22 — with GitHub Actions Inactive
@rokroskar
Copy link
Member

@olevski can we refresh this and get it merged?

@rokroskar rokroskar changed the base branch from master to release-0.60.0 October 11, 2024 18:21
@rokroskar
Copy link
Member

@olevski I rebased this on 0.60.0 and it seems to be all green (#3806) - if you agree, I can force-push my branch here and we can get it merged?

Copy link
Member Author

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve this because I opened the PR. But I looked through the changes and everything looks good.

@rokroskar rokroskar dismissed their stale review October 21, 2024 09:42

based on the old old version of things

@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://ci-renku-3297.dev.renku.ch

Copy link
Contributor

@aledegano aledegano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good.
For completeness I would also add to the file helm-chart/values.yaml.changelog.md the deletion of the corresponding values and re-iterating that the embedded Gitlab is gone.

@Panaetius Panaetius force-pushed the release-0.60.0 branch 3 times, most recently from 7502cda to ee8bbeb Compare October 28, 2024 14:31
@rokroskar rokroskar force-pushed the remove-internal-gitlab branch from 63adb08 to 8b8d779 Compare December 3, 2024 17:59
@rokroskar rokroskar changed the base branch from release-0.60.0 to release-0.62.0 December 3, 2024 17:59
@rokroskar
Copy link
Member

@aledegano I added the blurb

@rokroskar rokroskar merged commit 1c875af into release-0.62.0 Dec 4, 2024
18 checks passed
@rokroskar rokroskar deleted the remove-internal-gitlab branch December 4, 2024 10:39
@rokroskar rokroskar mentioned this pull request Dec 4, 2024
Panaetius pushed a commit that referenced this pull request Dec 18, 2024
Panaetius added a commit that referenced this pull request Dec 19, 2024
* chore: create release 0.62.0

* chore: update redis helm chart to latest revision (#3843)

* feat: remove internal gitlab (#3297)

Co-authored-by: Rok Roškar <[email protected]>

* Update search to release 0.7.0 (#3852)

* fix: point redis helm chart to the oci URI (#3855)

* tests: remove check of project container for anonymous users (#3853)

* feat: add support for session secrets in Renku 2.0 (#3837)

Closes #3832.

Add support for session secret slots and session secrets in Renku 2.0.

---------

Co-authored-by: Tasko Olevski <[email protected]>

* chore: add note about polybox/switchdrive to the top changelog (#3856)

* feat: update user and group pages design (#3857)


Co-authored-by: Flora Thiebaut <[email protected]>

* Update CHANGELOG.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Lionel Sambuc <[email protected]>
Co-authored-by: Tasko Olevski <[email protected]>
Co-authored-by: Rok Roškar <[email protected]>
Co-authored-by: eikek <[email protected]>
Co-authored-by: Andrea Cordoba <[email protected]>
Co-authored-by: Flora Thiebaut <[email protected]>
Co-authored-by: Tasko Olevski <[email protected]>
Co-authored-by: Rok Roškar <[email protected]>
Co-authored-by: Ralf Grubenmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants