fix(charts): gitlab chart template names #3288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledegano
previously approved these changes
Oct 6, 2023
olevski
force-pushed
the
fix-gitlab-chart-to-1
branch
from
de8af3d to
4d1e198
Compare
|
I guess this is superseded by #3297? |
|
Replaced by #3297 which will fully remove the internal gitlab helm chart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gitlab helm chart is using renkus templates i.e.
renku.httpbut before these were not prefixed byrenku.so we had to fix this there and publish a new version.The new version of the helm chart has been published. We just have to use it in the renku helm chart now.