chore: add single global Gitlab URL #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
|
Do you plan on following this up with changes in all the other charts? |
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
|
@rokroskar each team (well kg and rp) should have issues this sprint to switch over to using this. |
|
Got it! Can we add the issues as a todo list at the top of the PR to keep track? |
This was referenced Sep 7, 2023
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
Panaetius
had a problem deploying
to
ci-renku-3222
GitHub Actions
Error
Panaetius
had a problem deploying
to
ci-renku-3222
GitHub Actions
Failure
Panaetius
force-pushed
the
add-global-gitlab-url
branch
from
a352b86 to
c853e48
Compare
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://ci-renku-3222.dev.renku.ch |
Panaetius
had a problem deploying
to
ci-renku-3222
GitHub Actions
Error
Panaetius
had a problem deploying
to
ci-renku-3222
GitHub Actions
Error
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
Panaetius
temporarily deployed
to
ci-renku-3222
GitHub Actions
Inactive
rokroskar
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Great, this change makes a lot of sense now, thanks @Panaetius - just one thing we might want to do: existing deployments will fail because the registry host for the notebooks service is now expected to come from global.gitlab.registry.host - could you add a line to the values changelog that clarifies this?
rokroskar
approved these changes
Mar 28, 2024
|
@Panaetius I approved this but I'm not sure we should merge it right away - I think it should also require a change to values for CI deployments? |
Panaetius
added a commit
that referenced
this pull request
Apr 3, 2024
* chore: create release 0.50.x * chore(deps): bump azure/setup-helm from 3 to 4 (#3525) Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 3 to 4. - [Release notes](https://github.com/azure/setup-helm/releases) - [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md) - [Commits](Azure/setup-helm@v3...v4) --- updated-dependencies: - dependency-name: azure/setup-helm dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rok Roškar <[email protected]> * chore: update template versions (#3536) * chore: Remove `ui.client.url` from values as it is unused. (#3539) The value is not used anymore and we should remove it to avoid confusion. Co-authored-by: Rok Roškar <[email protected]> * chore(deps): bump actions/checkout from 4.1.1 to 4.1.2 (#3543) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.1...v4.1.2) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rok Roškar <[email protected]> * feat: renku 2.0 search (#3478) * chore: Renku search helm charts (#3481) * feat: add Solr to the subcharts. * feat: add message queue Redis to data-services (#3508) * chore: add gateway config for search endpoint * chore: add redis values for users sync svc * chore: add redis access to user sync job * chore: renku-graph 2.50.0 (with Jena 5.0.0) (#3549) * chore: renku-jena 0.0.25 * chore: graph updated to 2.50.0 * chore: streamline acceptance test dependencies (#3559) * chore: update changelog for release 0.50.0 (#3556) * chore(docs): improve the custom CA configuration part (#3552) The current version shows the configuration at the top level of the yaml while it should be under the global portion. * chore(docs): fix broken links to renku-python (#3063) Co-authored-by: Rok Roškar <[email protected]> Co-authored-by: Rok Roškar <[email protected]> Co-authored-by: Ralf Grubenmann <[email protected]> * chore: add sentry and prometheus for data services (#3548) * chore: clarify hidden features (#3561) * chore: Update selenium-java from 4.18.1 to 4.19.0 (#3560) * Upgrade search services to 0.0.39 (#3562) * Revert "chore: Update selenium-java from 4.18.1 to 4.19.0 (#3560)" This reverts commit c2af1f4. * chore: add single global Gitlab URL (#3222) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rok Roškar <[email protected]> Co-authored-by: Alessandro Degano <[email protected]> Co-authored-by: Lorenzo Cavazzi <[email protected]> Co-authored-by: Rok Roškar <[email protected]> Co-authored-by: Jakub Chrobasik <[email protected]> Co-authored-by: Flora Thiebaut <[email protected]> Co-authored-by: Samuel Gaist <[email protected]> Co-authored-by: bethcg <[email protected]> Co-authored-by: Ralf Grubenmann <[email protected]> Co-authored-by: Laura <[email protected]> Co-authored-by: eikek <[email protected]>
Panaetius
added a commit
that referenced
this pull request
Apr 3, 2024
Panaetius
added a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should replace all the places where we use gitlab URL in our services.
/deploy extra-values=global.gitlab.url=https://gitlab.dev.renku.ch,global.gitlab.registry.host=registry.dev.renku.ch