Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Removed double semicolon in C++ and OpenCL files #5155

Merged
merged 1 commit into from
Jan 24, 2025
Merged

STYLE: Removed double semicolon in C++ and OpenCL files #5155

merged 1 commit into from
Jan 24, 2025

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jan 23, 2025

This is a revival of #5135. Closes #5135.

PR Checklist

@github-actions github-actions bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module type:Style Style changes: no logic impact (indentation, comments, naming) labels Jan 23, 2025
@dzenanz dzenanz mentioned this pull request Jan 23, 2025
Closed
7 tasks
@blowekamp blowekamp self-requested a review January 23, 2025 20:00
blowekamp
blowekamp approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

jhlegarreta
jhlegarreta previously requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a proper commit message subject ("on files I could" is not relevant and add something more descriptive) and a commit body message, please.

@dzenanz dzenanz requested a review from jhlegarreta January 23, 2025 22:02
@jhlegarreta jhlegarreta changed the title STYLE: Removed double semicolon on files I could STYLE: Removed double semicolon in C++ and OpenCL files Jan 23, 2025
jhlegarreta
jhlegarreta reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit body message does not convey a meaningful message: the difficulty of doing this is not relevant; folks going over the git history are interested in what this fixes and why the fix was required.

@sananthanarayan @dzenanz
STYLE: Removed double semicolon in C++ and OpenCL files
2b2c853 
Double semicolons can confuse new developers.
They can also confuse automated analysis tools.
@hjmjohnson hjmjohnson merged commit 01b30b6 into InsightSoftwareConsortium:master Jan 24, 2025
15 checks passed
@dzenanz dzenanz mentioned this pull request Jan 24, 2025
Closed
@dzenanz dzenanz deleted the reborn_PR5135 branch January 24, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhlegarreta jhlegarreta jhlegarreta left review comments

@blowekamp blowekamp blowekamp approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dzenanz @hjmjohnson @blowekamp @jhlegarreta @sananthanarayan