Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double semicolons #5123

Open
dzenanz opened this issue Jan 6, 2025 · 8 comments
Open

Remove double semicolons #5123

dzenanz opened this issue Jan 6, 2025 · 8 comments
Assignees
Labels
Good first issue A good issue for community members new to contributing type:Style Style changes: no logic impact (indentation, comments, naming)

Comments

@dzenanz
Copy link
Member

dzenanz commented Jan 6, 2025

See discussion here for context:
#5108 (comment)

Double semicolons (;;) should only be removed from C++, not from bash etc.

@dzenanz dzenanz added Good first issue A good issue for community members new to contributing type:Style Style changes: no logic impact (indentation, comments, naming) labels Jan 6, 2025
@seanm
Copy link
Contributor

seanm commented Jan 7, 2025

BTW clang can fix these automatically with -Xclang -fix-only-warnings and -Wextra-semi

@dzenanz
Copy link
Member Author

dzenanz commented Jan 7, 2025

Could you give that a try, Sean?

@sananthanarayan
Copy link

@dzenanz Can I work on this issue?

@dzenanz
Copy link
Member Author

dzenanz commented Jan 16, 2025

Sure. If you don't make significant progress by the start of the hackathon next week, it would be good if you summarized your findings/impressions and unassigned yourself, so other hackathon attendees could have a crack at it.

@sananthanarayan
Copy link

@dzenanz Looking through just a few files so far and a lot of places where there is double semicolons are with for loops causing an infinite loop. This will require quite a lot of refactoring to ensure for loop performs at max efficiency

@sananthanarayan
Copy link

@dzenanz Here is the PR I created doing the files I could make changes to that were not for loops

@sananthanarayan
Copy link

#5135

@sananthanarayan
Copy link

@dzenanz I have undid the changes from the bash scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue A good issue for community members new to contributing type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Development

No branches or pull requests

3 participants