-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double semicolons #5123
Comments
BTW clang can fix these automatically with |
Could you give that a try, Sean? |
@dzenanz Can I work on this issue? |
Sure. If you don't make significant progress by the start of the hackathon next week, it would be good if you summarized your findings/impressions and unassigned yourself, so other hackathon attendees could have a crack at it. |
@dzenanz Looking through just a few files so far and a lot of places where there is double semicolons are with for loops causing an infinite loop. This will require quite a lot of refactoring to ensure for loop performs at max efficiency |
@dzenanz Here is the PR I created doing the files I could make changes to that were not for loops |
@dzenanz I have undid the changes from the bash scripts. |
See discussion here for context:
#5108 (comment)
Double semicolons (
;;
) should only be removed from C++, not from bash etc.The text was updated successfully, but these errors were encountered: