Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: removed double semicolon on files I could #5135

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

STYLE: removed double semicolon on files I could #5135

wants to merge 7 commits into from
+29 −29

Conversation

sananthanarayan
Copy link

@sananthanarayan sananthanarayan commented Jan 16, 2025 •
edited
Loading

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:ThirdParty Issues affecting the ThirdParty module type:Style Style changes: no logic impact (indentation, comments, naming) labels Jan 16, 2025
github-actions[bot]
github-actions bot reviewed Jan 16, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing a pull request! 🙏

Welcome to the ITK community! 🤗👋☀️

We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖

This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.

@sananthanarayan sananthanarayan mentioned this pull request Jan 16, 2025
Open
dzenanz
dzenanz requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should revert changes to shell scripts.

Modules/ThirdParty/HDF5/src/itkhdf5/c++/src/h5c++.in Outdated
@@ -172,7 +172,7 @@ fi
case "$CXX" in
gcc)
kind="gcc"
;;
;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a shell script. As such, double semicolon has a special meaning, see e.g. https://stackoverflow.com/questions/16905183/dash-double-semicolon-syntax

So are most of the other files in this change list.

Modules/Filtering/GPUAnisotropicSmoothing/src/GPUGradientNDAnisotropicDiffusionFunction.cl Show resolved Hide resolved
@github-actions github-actions bot removed the type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct label Jan 17, 2025
@github-actions github-actions bot removed the area:Core Issues affecting the Core module label Jan 17, 2025
@github-actions github-actions bot removed the area:ThirdParty Issues affecting the ThirdParty module label Jan 17, 2025
dzenanz
dzenanz reviewed Jan 17, 2025
View reviewed changes
Utilities/Hooks/kw-pre-commit
@@ -99,11 +99,11 @@ check_whitespace() {
sed 's/^[^:]*: whitespace: //')
if $approx_tab_in_indent; then
case ",$ws," in
*,tab-in-indent,*) check_tab "$1" ;;
*,tab-in-indent,*) check_tab "$1" ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most hooks are bash scripts, including this one.

Utilities/GitSetup/git-review-push
--) shift; break ;;
-*) usage ;;
*) test -z "$remote" || usage ; remote="$1" ;;
--no-topic) no_topic=1 ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a bash script.

dzenanz
dzenanz reviewed Jan 17, 2025
View reviewed changes
Modules/Core/Common/src/itkBuildInformation.cxx.in Outdated
@@ -87,7 +87,7 @@ BuildInformation::GetValue(const MapKeyType & key)
{
return it->second.m_Value;
}
return {};;
return {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a C++ file, the changes here should be kept.

@jhlegarreta
Copy link
Member

@sananthanarayan Please read our contributing guidelines:
https://docs.itk.org/en/latest/contributing/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@dzenanz dzenanz dzenanz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area:Filtering Issues affecting the Filtering module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sananthanarayan @jhlegarreta @dzenanz