Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label action #2744

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Fix label action #2744

merged 2 commits into from
Jan 24, 2025

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jan 22, 2025

This seems to have gone wrong in #2736, so trying to fix here.

Because the job is defined using pull_request_target, it's run from the GH actions config on the main branch, so this will need merging to fix the job.

@moradology
Copy link
Contributor

This proved to require an odd and detailed intervention. Assuming the efforts in #2747 are accepted, I think this PR can be closed

@martindurant
Copy link
Member

Because the job is defined using pull_request_target, it's run from the GH actions config on the main branch, so this will need merging to fix the job.

I like the simplicity of this fix, but how do we know if it works? Should we merge and see what happens?

@dstansby
Copy link
Contributor Author

Yes, it will need merging to verify if it works .

@moradology
Copy link
Contributor

Can technically swap over to target pull_request but I'd say just pull the trigger and clean up later

@jhamman
Copy link
Member

jhamman commented Jan 24, 2025

Can we get this merged now? The failing labeler is causing CI checks to fail on all PRs.

@dstansby
Copy link
Contributor Author

Sure, it just needs a maintainer to review/approve/merge.

@d-v-b d-v-b enabled auto-merge (squash) January 24, 2025 14:20
@martindurant
Copy link
Member

@d-v-b , will auto-merge happen if the labeler run fails? (as it will, since it won't take action until its in main)

@d-v-b
Copy link
Contributor

d-v-b commented Jan 24, 2025

@d-v-b , will auto-merge happen if the labeler run fails? (as it will, since it won't take action until its in main)

I was wondering the same thing. we shall see!

@d-v-b d-v-b disabled auto-merge January 24, 2025 14:30
@d-v-b d-v-b merged commit 40da497 into zarr-developers:main Jan 24, 2025
29 of 30 checks passed
@dstansby dstansby deleted the fix-labeler branch January 24, 2025 14:37
@dstansby
Copy link
Contributor Author

Looks like this worked: https://github.com/zarr-developers/zarr-python/actions/runs/12951743813/job/36127460117?pr=2714 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants