Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labeler action is unclear #2745

Closed
d-v-b opened this issue Jan 22, 2025 · 5 comments
Closed

labeler action is unclear #2745

d-v-b opened this issue Jan 22, 2025 · 5 comments
Labels

Comments

@d-v-b
Copy link
Contributor

d-v-b commented Jan 22, 2025

We have a new check for PRs. I think it should convey more information when it fails -- the current error output is far too obscure to do anything with:

Run actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Error: Error: found unexpected type for label '0' (should be array of config options)
Error: found unexpected type for label '0' (should be array of config options)
@d-v-b d-v-b added the chore label Jan 22, 2025
@d-v-b d-v-b assigned d-v-b and dstansby and unassigned d-v-b Jan 22, 2025
@d-v-b
Copy link
Contributor Author

d-v-b commented Jan 22, 2025

looks like this arrived via #2736.

@dstansby
Copy link
Contributor

See #2744 for what I think is a fix

@d-v-b
Copy link
Contributor Author

d-v-b commented Jan 22, 2025

what does this action do? and how does #2744 fix the obscure error message? When I look at the failed labeller action in #2744 it looks just as obscure as the one I got

@dstansby
Copy link
Contributor

dstansby commented Jan 22, 2025

It automatically labels PRs that need to add a release notes entry. #2744 doesn't improve the error message, but it should fix the error.

I think the confusing error message would be an upstream issue for https://github.com/actions/labeler.

@dstansby dstansby removed their assignment Jan 22, 2025
@d-v-b
Copy link
Contributor Author

d-v-b commented Jan 25, 2025

i think this can be closed

@d-v-b d-v-b closed this as completed Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants