Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1411) Cleanup pom, bump parent and add todo for junit 5 #1412

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

victornoel
Copy link
Collaborator

This is for #1411.

@0crat
Copy link
Collaborator

0crat commented Jul 5, 2020

This pull request #1412 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jul 5, 2020

The architect of the project has changed; @paulodamaso/z is not at this role anymore; @victornoel/z is the architect now

@victornoel
Copy link
Collaborator Author

@0crat in

@victornoel
Copy link
Collaborator Author

@0crat assign @marceloamadeu

@0crat
Copy link
Collaborator

0crat commented Jul 5, 2020

This pull request #1412 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jul 5, 2020

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@d30d334c-b8f5-4e54-8f5c-30e1e363cf4f, thread: PQ-C63314D6Z
com.jcabi.xml.StrictXML[124] java.lang.IllegalArgumentException: 1 error(s) in XML document: -1:-1: Duplicate unique value [gh:yegor256/cactoos#1412] declared for identity constraint of element "agenda".

0.53.15: CID: 5fe0b068-aec9-475e-a5d2-a3c2a7f2c507, Type: "Order was given"

@codecov-commenter
Copy link

Codecov Report

Merging #1412 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1412   +/-   ##
=========================================
  Coverage     89.79%   89.79%           
  Complexity     1687     1687           
=========================================
  Files           276      276           
  Lines          4006     4006           
  Branches        211      211           
=========================================
  Hits           3597     3597           
  Misses          376      376           
  Partials         33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3675019...033b34e. Read the comment docs.

@fabriciofx
Copy link
Contributor

@victornoel Oh-oh, right! I confused 5.6.2 with 5.4.2! Sorry!

Copy link
Contributor

@marceloamadeu marceloamadeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victornoel looks good to me

@victornoel
Copy link
Collaborator Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 7, 2020

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 033b34e into yegor256:master Jul 7, 2020
@rultor
Copy link
Collaborator

rultor commented Jul 7, 2020

@rultor merge

@victornoel Done! FYI, the full log is here (took me 10min)

@victornoel victornoel deleted the 1411 branch July 7, 2020 12:19
@0crat 0crat added the qa label Jul 7, 2020
@0crat
Copy link
Collaborator

0crat commented Jul 7, 2020

Job was finished in 45 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the scope label Jul 7, 2020
@0crat
Copy link
Collaborator

0crat commented Jul 7, 2020

@sereshqua/z please review this job completed by @marceloamadeu/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Jul 7, 2020

Quality is low, no payment, see §31

@0crat 0crat added quality/bad and removed qa labels Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants