-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1411) Cleanup pom, bump parent and add todo for junit 5 #1412
Conversation
This pull request #1412 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
The architect of the project has changed; @paulodamaso/z is not at this role anymore; @victornoel/z is the architect now |
@0crat in |
@0crat assign @marceloamadeu |
This pull request #1412 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
There is an unrecoverable failure on my side. Please, submit it here:
0.53.15: CID: 5fe0b068-aec9-475e-a5d2-a3c2a7f2c507, Type: "Order was given" |
Codecov Report
@@ Coverage Diff @@
## master #1412 +/- ##
=========================================
Coverage 89.79% 89.79%
Complexity 1687 1687
=========================================
Files 276 276
Lines 4006 4006
Branches 211 211
=========================================
Hits 3597 3597
Misses 376 376
Partials 33 33 Continue to review full report at Codecov.
|
@victornoel Oh-oh, right! I confused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victornoel looks good to me
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 10min) |
Job was finished in 45 hours, bonus for fast delivery is possible (see §36) |
@sereshqua/z please review this job completed by @marceloamadeu/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality bad |
Quality is low, no payment, see §31 |
This is for #1411.