Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven-compiler-plugin and fix bug on it to allow incremental compilation #112

Closed
fabriciofx opened this issue Apr 24, 2019 · 6 comments

Comments

@fabriciofx
Copy link

Let's update maven-compiler-plugin to 3.8.0 version and fix a bug in this plugin which doesn't allow incremental compilation that increase compile and running time. To fix both we need change pom.xml to:

<plugin>
  <artifactId>maven-compiler-plugin</artifactId>
  <version>3.8.0</version>
  <configuration>
    <source>1.8</source>
    <target>1.8</target>
    <useIncrementalCompilation>false</useIncrementalCompilation>
  </configuration>
</plugin>

Please, pay attention to <version> and <useIncrementalCompilation> tag.

@0crat
Copy link
Collaborator

0crat commented Apr 24, 2019

@llorllale/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Apr 24, 2019

@fabriciofx/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@victornoel
Copy link
Collaborator

@fabriciofx the objective is is to disable incremental compilation? Why do we want to do that? I see the other cactoos projects have this kind of setup, I don't understand why exactly, do you know?

@fabriciofx
Copy link
Author

@victornoel I opened this issue a lot of time ago. It's because there is (or was) a bug in maven-compiler-plugin. I think this bug already was fixed. So, I'll close it, ok?

@0crat
Copy link
Collaborator

0crat commented Jul 5, 2020

Job gh:llorllale/cactoos-matchers#112 is not assigned, can't get performer

@victornoel
Copy link
Collaborator

@fabriciofx ok, thank you, I removed the option in yegor256/cactoos#1412 for cactoos (I will do cactoos-matchers later) so we will see what happens without it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants