Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ease development of server-side viewer panels #1092

Merged
merged 14 commits into from
Nov 28, 2024
Merged

Ease development of server-side viewer panels #1092

merged 14 commits into from
Nov 28, 2024

Conversation

forman
Copy link
Member

@forman forman commented Nov 26, 2024 •
edited
Loading

  • Added a useful 2D-Histogram demo case
  • Added get_dataset() to the context passed to contributions.
  • Adjusted examples to Chartlets 0.0.28.

See xcube-dev/xcube-viewer#451

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman mentioned this pull request Nov 26, 2024
Merged
@forman forman self-assigned this Nov 26, 2024
@forman forman marked this pull request as ready for review November 26, 2024 13:28
@forman forman requested a review from b-yogesh November 26, 2024 13:29
b-yogesh
b-yogesh approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@forman forman merged commit d3f0b6c into main Nov 28, 2024
2 of 3 checks passed
@forman forman deleted the forman-x-ease_impl_of_server_side_viewer_panels branch January 14, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-yogesh b-yogesh b-yogesh approved these changes

Assignees

@forman forman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forman @b-yogesh