Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease development of server-side viewer panels #451

Merged
merged 11 commits into from
Nov 29, 2024

Conversation

forman
Copy link
Member

@forman forman commented Nov 26, 2024

Changes:

  • Added developer reference docs generated from derived state's property descriptions
  • New module ext that deals solely with the server-side contributions
  • Introduced new derived state for server-side contributions
  • Updated the demo panel "2D Histogram", it is still lacking some useful features like showing progress, disablement, and some info text

To verify

  • make sure dev reference works: extensions and derived state is documented
  • make sure the demo panels work, please leave comments with possible enhancements or ideas for other panels

See xcube-dev/xcube#1092

@forman forman removed the request for review from clarasb November 28, 2024 14:45
@forman forman marked this pull request as ready for review November 28, 2024 14:46
…_viewer_panels

# Conflicts:
#	CHANGES.md
#	src/actions/dataActions.tsx
#	src/connected/AppBar.tsx
@forman forman requested a review from clarasb November 29, 2024 08:57
Copy link
Collaborator

@clarasb clarasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature work fine.

As requested, here are some ideas for enhancements:

  • Adding the place name to the plot, otherwise there is no obvious/visual connection between the plot in the panel and the place.
  • When creating new places, the Viewer automatically jumps to the 'Time Series' panel. This is a bit confusing if the user is in the '2D-Histogramm' panel and wants to create a new place for a new 2D-Histogramm.
  • In the other panels, the control features (buttons etc.) are placed at the top of the panel. For consistency, the controls in this panel could also be placed at the top instead of the bottom.

Another panel idea: a simple histogram only for one variable

(tested from a user-perspective)

@forman
Copy link
Member Author

forman commented Nov 29, 2024

As requested, here are some ideas for enhancements

Thanks! Once we have a new release, let's please add those as a feature request.

@forman forman merged commit 74991ef into main Nov 29, 2024
3 checks passed
@forman forman deleted the forman-x-ease_impl_of_server_side_viewer_panels branch November 29, 2024 12:29
@clarasb
Copy link
Collaborator

clarasb commented Nov 29, 2024

@forman done, see #452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants