-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle multi-email and mobile feature based on user store exclusion and support by default config #872
Toggle multi-email and mobile feature based on user store exclusion and support by default config #872
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
============================================
- Coverage 36.53% 36.53% -0.01%
- Complexity 1475 1485 +10
============================================
Files 267 267
Lines 15815 15819 +4
Branches 2183 2180 -3
============================================
+ Hits 5778 5779 +1
- Misses 9321 9326 +5
+ Partials 716 714 -2 ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11617260684
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11643547382
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11659583898
Proposed changes in this pull request
Additional Context: LDAP does not provide default support for the newly introduced claims - emailAddresses, verifiedEmailAddresses, mobileNumbers, and verifiedMobileNumbers. This limitation creates an issue where attempts to update even basic primary email or mobile numbers can be blocked, as the system in some scenarios tries to update these unsupported multiple-value claims. To resolve this critical issue, the system will now only attempt to update these new claims if at least one of them is explicitly present in the update request, ensuring that essential primary email/mobile updates remain functional.
Related Issues
Related PRs