Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ExcludedUserStoreDomains constant. #6096

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

PasinduYeshan
Copy link
Contributor

Proposed changes in this pull request

Introduce new claim property to have excluded user store domain names.

Related Issues

Related PRs

Additional Context

Multiple Emails and Mobile Numbers Feature: This improvement is particularly beneficial for features like multiple emails and mobile numbers per user. With this feature enabled, UIs display multiple claims instead of a single claim, treating one as the primary number. By excluding user stores that do not support certain attributes, we prevent errors when these features attempt to update unsupported attributes.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11650719913

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.74%. Comparing base (9800fe8) to head (27a0275).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6096      +/-   ##
============================================
+ Coverage     40.54%   40.74%   +0.19%     
+ Complexity    14465    14451      -14     
============================================
  Files          1762     1762              
  Lines        118284   117628     -656     
  Branches      20454    20321     -133     
============================================
- Hits          47960    47928      -32     
+ Misses        63011    62421     -590     
+ Partials       7313     7279      -34     
Flag Coverage Δ
unit 25.01% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11650719913
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11650719913

Copy link

sonarqubecloud bot commented Nov 4, 2024

@PasinduYeshan PasinduYeshan merged commit 4280f01 into wso2:master Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants