orb-ui: show car simulation

[fouge]

No description provided.

[TheButlah]

You already filter *.wav. Are these actually necessary?

[TheButlah]

I usually use Instant since it is monotonic.

[TheButlah]

Usually we should always use std::time::Duration. Is there a reason you chose a f64 here?

[fouge]

dt is f64 so it's very simple to use it like this

[TheButlah]

Suggested change

	"ArcDash"
	std::any::type_name::<Self>()

Try doing it this way in the default trait impl to remove the repetition. If that doesn't work, then just do it on each struct like you already do.

[fouge]

I did it like this

[TheButlah]

why is superseded a dyn Any? Why is failure to transition a thing at all?

[fouge]

it's now returning the bool only

[TheButlah]

You need comments to explain what each one of these numbers are.

[TheButlah]

strange to have a config but not actually make it configurable.

I suggest:

#[derive(Debug, Eq, PartialEq, Clone)]
struct MilkyWayConfig  {
    pub background: Argb,
    pub fade_delta: i8,
    pub red_delta: i8,
    pub green_delta: i8,
    pub blue_delta: i8,
    pub red_min_max: (u8, u8),
    pub green_min_max: (u8, u8),
    pub blue_min_max: (u8, u8),
}

// Refer to things with named presets instead of "default". Fewer implicit assumptions down the line.
impl MilkyWayConfig {
    fn descriptive_name_for_preset() -> Self {
        Self { ... } // fill in values for the preset
    }

    fn another_preset() -> Self {
        Self { .. } // fill values
    }
}


impl MilkyWay {
    pub fn new(config: MilkyWayConfig) { ... }
}

Here's how you use it:

// Use struct update syntax to only override some of the fields of the preset
MilkyWay::new(MilkyWayConfig { background: Argb::red(), fade_delta: 2, ..MilkyWayConfig::descriptive_name_for_preset()})
// Use the preset without customization.
MilkyWay::new(MilkyWayConfig::descriptive_name_for_preset())
// Use a different preset
MilkyWay::new(MilkyWayConfig::another_preset())

[TheButlah]

Use expect and not allow

[TheButlah]

It is possible to make this a const NAME: &str; in the trait instead of a method? Asking if possible because im not sure if the const will work with trait objects.

[TheButlah]

Instead of using a name method, why not use a kind method that returns a enum AnimationKind { ArcDash, MilkyWay, ... } that identifies which animation it is?

That enum can then just be printed with Debug.