Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved CI #12

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Improved CI #12

merged 1 commit into from
Mar 19, 2024

Conversation

TheButlah
Copy link
Collaborator

No description provided.

@TheButlah TheButlah force-pushed the thebutlah/cargo-deny branch from 9e62e04 to 128da57 Compare March 7, 2024 16:51
@TheButlah TheButlah force-pushed the main branch 2 times, most recently from f84b0dd to 92497b3 Compare March 13, 2024 05:28
@TheButlah TheButlah force-pushed the thebutlah/cargo-deny branch from 1ee5f85 to ef57e7b Compare March 17, 2024 03:55
@TheButlah TheButlah requested a review from fouge March 17, 2024 03:57
fouge
fouge requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@fouge fouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you squash all commits into one before merging with rebase (the last 2 aren't needed if you edit the first one, and I think it makes sense to have only one commit for this PR

@TheButlah
Copy link
Collaborator Author

TheButlah commented Mar 19, 2024 •
edited
Loading

Isn't that identical to a "squash merge" strategy?

Regardless, I've gone ahead and rebased as requested.

@TheButlah TheButlah force-pushed the thebutlah/cargo-deny branch from ef57e7b to a4a5923 Compare March 19, 2024 02:12
@TheButlah TheButlah requested a review from fouge March 19, 2024 02:15
@TheButlah
Copy link
Collaborator Author

rebase merge won't work. Even though my commit is signed, github won't allow me to click the button.
I'm going to squash merge instead

@TheButlah TheButlah merged commit 4941fd6 into main Mar 19, 2024
5 checks passed
@TheButlah TheButlah deleted the thebutlah/cargo-deny branch March 19, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fouge fouge Awaiting requested review from fouge fouge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheButlah @fouge