fix: revert minimized calling cell #17696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-navigation #17696 +/- ##
==================================================
- Coverage 46.38% 46.33% -0.05%
==================================================
Files 779 774 -5
Lines 25201 25193 -8
Branches 5765 5762 -3
==================================================
- Hits 11690 11674 -16
- Misses 12046 12054 +8
Partials 1465 1465 |
V-Gira
approved these changes
Jul 5, 2024
PatrykBuniX
added a commit
that referenced
this pull request
Jul 10, 2024
This reverts commit 62ec5a5.
This was referenced Jul 16, 2024
Merged
PatrykBuniX
added a commit
that referenced
this pull request
Jul 26, 2024
* feat: put fullscreen ui into detached calling cell * runfix: make sure less styles are properly overwritten with emotion * runfix: make screenshare work on browser * feat: do not allow in-app fullscreen anymore * runfix: remove labels from full ui buttons * runfix: align margins * feat: add useToggleState hook * feat: select call view mode * feat: align icons styles and labels * runfix: align changes after rebasing * tmp * Revert "fix: remove unused component (#17681)" This reverts commit 2689225. * feat: add participants label * feat: toggle participants list * runfix: mic off icon * runfix: call tab view styles * runfix: put fullscreen into the webapp temp * runfix: icon styles on dark mode * tmp * runfix: active window match media * runfix: screenshare button * runfix: revert extra handling of separate window media devices * runfix: screen sharing on desktop * chore: self-review * runfix: rename variable * test: align tests * test: align tests * chore: hide detached window on desktop * feat: move call pagination to top bar * runfix: apply theme change during fullscreen call * Revert "fix: revert minimized calling cell (#17696)" This reverts commit 62ec5a5. * runfix: last overflowed participant list item not visible * chore: add debug util for adding a participant to the active call * runfix: default call avatar size * chore: remove debug util to enable the feature
PatrykBuniX
added a commit
that referenced
this pull request
Jul 26, 2024
* feat: put fullscreen ui into detached calling cell * runfix: make sure less styles are properly overwritten with emotion * runfix: make screenshare work on browser * feat: do not allow in-app fullscreen anymore * runfix: remove labels from full ui buttons * runfix: align margins * feat: add useToggleState hook * feat: select call view mode * feat: align icons styles and labels * runfix: align changes after rebasing * tmp * Revert "fix: remove unused component (#17681)" This reverts commit 2689225. * feat: add participants label * feat: toggle participants list * runfix: mic off icon * runfix: call tab view styles * runfix: put fullscreen into the webapp temp * runfix: icon styles on dark mode * tmp * runfix: active window match media * runfix: screenshare button * runfix: revert extra handling of separate window media devices * runfix: screen sharing on desktop * chore: self-review * runfix: rename variable * test: align tests * test: align tests * chore: hide detached window on desktop * feat: move call pagination to top bar * runfix: apply theme change during fullscreen call * Revert "fix: revert minimized calling cell (#17696)" This reverts commit 62ec5a5. * runfix: last overflowed participant list item not visible * chore: add debug util for adding a participant to the active call * runfix: default call avatar size * chore: remove debug util to enable the feature
thisisamir98
added a commit
that referenced
this pull request
Aug 2, 2024
* feat: calling popout version 2 (#17733) * feat: put fullscreen ui into detached calling cell * runfix: make sure less styles are properly overwritten with emotion * runfix: make screenshare work on browser * feat: do not allow in-app fullscreen anymore * runfix: remove labels from full ui buttons * runfix: align margins * feat: add useToggleState hook * feat: select call view mode * feat: align icons styles and labels * runfix: align changes after rebasing * tmp * Revert "fix: remove unused component (#17681)" This reverts commit 2689225. * feat: add participants label * feat: toggle participants list * runfix: mic off icon * runfix: call tab view styles * runfix: put fullscreen into the webapp temp * runfix: icon styles on dark mode * tmp * runfix: active window match media * runfix: screenshare button * runfix: revert extra handling of separate window media devices * runfix: screen sharing on desktop * chore: self-review * runfix: rename variable * test: align tests * test: align tests * chore: hide detached window on desktop * feat: move call pagination to top bar * runfix: apply theme change during fullscreen call * Revert "fix: revert minimized calling cell (#17696)" This reverts commit 62ec5a5. * runfix: last overflowed participant list item not visible * chore: add debug util for adding a participant to the active call * runfix: default call avatar size * chore: remove debug util to enable the feature * feat: new reactions menu design * feat: adjust reactions popup styles * feat: use new emoji icon * refactor: move detached window to call state * refactor: remove extra types * refactor: remove twice assignment of variable * refactor: add thumbnail to ElectronDesktopCapturerSource * refactor: immediately minimize call on hangup button click --------- Co-authored-by: Amir Ghezelbash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)