runfix: re-implement indicator on settings button when a new device is added (WPB-9542) #17763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s added (WPB-9542)
V-Gira
commented
Jul 16, 2024
| content: ''; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the style for the previous button and indicator badge and can be removed
|
V-Gira
commented
Jul 16, 2024
| @@ -184,7 +184,7 @@ export const ConversationTabs = ({ | |||
| }} | |||
| conversationTabIndex={1} | |||
| dataUieName="go-preferences" | |||
| showNotificationBadge={showNotificationsBadge} | |||
| showNotificationsBadge={showNotificationsBadge} | |||
There was a problem hiding this comment.
spelling "notification" in singular didn't seem intentional
thisisamir98
approved these changes
Jul 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-navigation #17763 +/- ##
==================================================
- Coverage 46.21% 46.21% -0.01%
==================================================
Files 770 770
Lines 25057 25058 +1
Branches 5737 5737
==================================================
Hits 11581 11581
- Misses 12020 12021 +1
Partials 1456 1456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The indicator for new device added implemented here #17695 was removed by mistake here #17696
Screenshots/Screencast (for UI changes)
Before:
After:
