Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notifications stop working when switching backend - WPB-15127 #2389

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −1
Open

fix: notifications stop working when switching backend - WPB-15127 #2389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion wire-ios/WireCommonComponents/BackendEnvironment+Shared.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ private let zmsLog = ZMSLog(tag: "backend-environment")
public extension BackendEnvironment {
static let backendSwitchNotification = Notification.Name("backendEnvironmentSwitchNotification")
static var shared: BackendEnvironment = {
var environmentType: EnvironmentType?
// read from userDefaults first
var environmentType: EnvironmentType? = EnvironmentType(userDefaults: .applicationGroup)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think environmentType needs to be optional after your change and you can do something like the following to remove the var too:

        let environmentType: EnvironmentType
        if let typeOverride = AutomationHelper.sharedHelper.backendEnvironmentTypeOverride() {
            environmentType = EnvironmentType(stringValue: typeOverride)
        } else {
            environmentType = EnvironmentType(userDefaults: .applicationGroup)
        }

if let typeOverride = AutomationHelper.sharedHelper.backendEnvironmentTypeOverride() {
environmentType = EnvironmentType(stringValue: typeOverride)
}
Expand Down
Loading