fix: notifications stop working when switching backend - WPB-15127

[netbe]

WPB-15127 [iOS] Notifications stop working

Issue

When switching backend after logging out from an account and then log to a new account, the NSE will not work because the cookie is invalid.

This is due to the fact that the environmentType (prod, staging,...), although it is correctly saved to applicationGroup UserDefaults for the NSE to work correctly, it does not read from the UserDefaults. Therefore it falls back to production and invalidates the session.

Solution:

Read environmentType from applicationGroup in BackendEnvironment.shared.

Testing

• See steps in ticket to reproduce

Note: as the code is in a static variable it is hard to add a unit test.

---

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

[github-actions]

Test Results

    1 files      2 suites   1m 58s ⏱️
1 793 tests 1 767 ✅ 26 💤 0 ❌
1 803 runs  1 777 ✅ 26 💤 0 ❌

Results for commit 446bf6b.

[datadog-wireapp]

Datadog Report

Branch report: fix/WPB-15127-notifications-stop-working
Commit report: d2adfe2
Test service: wire-ios-mono

✅ 0 Failed, 1689 Passed, 26 Skipped, 1m 58.36s Total Time

[samwyndham]

I don't think environmentType needs to be optional after your change and you can do something like the following to remove the var too:

        let environmentType: EnvironmentType
        if let typeOverride = AutomationHelper.sharedHelper.backendEnvironmentTypeOverride() {
            environmentType = EnvironmentType(stringValue: typeOverride)
        } else {
            environmentType = EnvironmentType(userDefaults: .applicationGroup)
        }