Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open password reset link in browser - WPB-11685 #2095

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

El-Fitz
Copy link
Contributor

@El-Fitz El-Fitz commented Oct 25, 2024

BugWPB-11685 [iOS] Wire app ignores default browser setting for static links - C builds

Issue

The password reset & forgot password links should be opened in the selected browser instead of a Safari web view.

Testing

Go to account -> settings -> account -> reset password.
Tap the button. The password reset page should open in your selected browser.

Logout
Log in -> Forgot password?
Tap the link. The password reset page should open in your selected browser.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@El-Fitz El-Fitz requested review from netbe and agisilaos October 25, 2024 13:48
@El-Fitz El-Fitz self-assigned this Oct 25, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 25, 2024
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Test Results

1 858 tests   1 855 ✅  2m 5s ⏱️
  304 suites      0 💤
    1 files        3 ❌

For more details on these failures, see this check.

Results for commit c989802.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 25, 2024

Datadog Report

Branch report: feat/open-password-reset-link-in-browser
Commit report: e0768cc
Test service: wire-ios-mono

❌ 3 Failed (0 Known Flaky), 1855 Passed, 0 Skipped, 5.07s Total Time

❌ Failed Tests (3)

  • testThatItRendersMissedCallFromOtherUserInGroup - Wire_iOS_Tests.CallSystemMessageTests - Details

    Expand for error
     Invalid number of stores (NSInternalInconsistencyException)
     
     wire-ios/Wire-iOS Tests/CallSystemMessageTests.swift:32
    
  • testThatItDisplaysAudioMessage_55 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error
     XCTAssertTrue failed
     
     wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493
    
  • testThatItDisplaysErrorForDeletedMessage_57 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error
     XCTAssertTrue failed
     
     wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493
    

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale label Nov 28, 2024
@netbe netbe enabled auto-merge (squash) November 28, 2024 15:23
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking this for next C builds, should be ported to develop via cherry-pick action

@caldrian caldrian force-pushed the feat/open-password-reset-link-in-browser branch from e65a4ce to 347e06d Compare November 28, 2024 16:42
@github-actions github-actions bot removed the stale label Nov 29, 2024
@netbe netbe self-assigned this Jan 17, 2025
@netbe netbe disabled auto-merge January 17, 2025 16:24
@netbe netbe merged commit 4714bdf into release/cycle-3.112 Jan 17, 2025
8 of 10 checks passed
@netbe netbe deleted the feat/open-password-reset-link-in-browser branch January 17, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants