-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open password reset link in browser - WPB-11685 #2095
feat: open password reset link in browser - WPB-11685 #2095
Conversation
Test Results1 858 tests 1 855 ✅ 2m 5s ⏱️ For more details on these failures, see this check. Results for commit c989802. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ❌ 3 Failed (0 Known Flaky), 1855 Passed, 0 Skipped, 5.07s Total Time ❌ Failed Tests (3)
|
wire-ios/Wire-iOS/Sources/Authentication/Coordinator/AuthenticationCoordinator.swift
Show resolved
Hide resolved
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking this for next C builds, should be ported to develop via cherry-pick action
e65a4ce
to
347e06d
Compare
Issue
The password reset & forgot password links should be opened in the selected browser instead of a Safari web view.
Testing
Go to account -> settings -> account -> reset password.
Tap the button. The password reset page should open in your selected browser.
Logout
Log in -> Forgot password?
Tap the link. The password reset page should open in your selected browser.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: