-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open password reset link in browser - WPB-11685 #2398
feat: open password reset link in browser - WPB-11685 #2398
Conversation
Test Results 1 files 2 suites 2m 0s ⏱️ Results for commit bd4bedb. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1689 Passed, 26 Skipped, 1m 59.82s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the original PR there are changes in
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Account.swift
https://github.com/wireapp/wire-ios/pull/2095/files#diff-7fce994c6ed800e29415a334545487086caa4bc9de48971dd03487639cf8d62fL351-R352
Aren't those needed on develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The submodule should not be changed. + I think @caldrian might have a point for the SettingsCellDescriptorFactory+Account.swift changes
7de7f38
to
6058cda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;)
Cherry pick from the original PR:
wire-ios/Wire-iOS/Sources/Authentication/Coordinator/AuthenticationCoordinator.swift
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Account.swift
Issue
The password reset & forgot password links should be opened in the selected browser instead of a Safari web view.
Testing
Go to account -> settings -> account -> reset password.
Tap the button. The password reset page should open in your selected browser.
Logout
Log in -> Forgot password?
Tap the link. The password reset page should open in your selected browser.
Checklist
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: