Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open password reset link in browser - WPB-11685 #2398

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
wire-ios/Wire-iOS/Sources/Authentication/Coordinator/AuthenticationCoordinator.swift
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Account.swift

BugWPB-11685 [iOS] Wire app ignores default browser setting for static links - C builds

Issue

The password reset & forgot password links should be opened in the selected browser instead of a Safari web view.

Testing

Go to account -> settings -> account -> reset password.
Tap the button. The password reset page should open in your selected browser.

Logout
Log in -> Forgot password?
Tap the link. The password reset page should open in your selected browser.


Checklist

  • Title contains a reference JIRA issue number like .
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jan 17, 2025
Copy link
Contributor Author

github-actions bot commented Jan 17, 2025

Test Results

    1 files      2 suites   2m 0s ⏱️
1 793 tests 1 767 ✅ 26 💤 0 ❌
1 803 runs  1 777 ✅ 26 💤 0 ❌

Results for commit bd4bedb.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 17, 2025

Datadog Report

Branch report: feat/open-password-reset-link-in-browser-cherry-pick
Commit report: e8b78ad
Test service: wire-ios-mono

✅ 0 Failed, 1689 Passed, 26 Skipped, 1m 59.82s Total Time

@El-Fitz El-Fitz enabled auto-merge January 17, 2025 18:17
Copy link
Contributor

@caldrian caldrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original PR there are changes in
wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Account.swift
https://github.com/wireapp/wire-ios/pull/2095/files#diff-7fce994c6ed800e29415a334545487086caa4bc9de48971dd03487639cf8d62fL351-R352

Aren't those needed on develop?

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule should not be changed. + I think @caldrian might have a point for the SettingsCellDescriptorFactory+Account.swift changes

@El-Fitz El-Fitz force-pushed the feat/open-password-reset-link-in-browser-cherry-pick branch from 7de7f38 to 6058cda Compare January 20, 2025 13:41
@El-Fitz El-Fitz requested review from netbe and caldrian January 20, 2025 16:08
@El-Fitz El-Fitz disabled auto-merge January 20, 2025 16:08
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@El-Fitz El-Fitz added this pull request to the merge queue Jan 21, 2025
Merged via the queue into develop with commit 82076e8 Jan 21, 2025
11 checks passed
@El-Fitz El-Fitz deleted the feat/open-password-reset-link-in-browser-cherry-pick branch January 21, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants