Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accessibility strings founded issues #WPB-9784 #3657

Merged

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Nov 22, 2024

TaskWPB-9784 [Android] accessibility strings – Conversation details

What's new in this PR?

Issues

While testing accessibility strings Astrid found some small issues in ConversationsList ConversationDetails and SelfProfile screens.

Solutions

Fix the issues

@borichellow borichellow self-assigned this Nov 22, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.33%. Comparing base (9a791bf) to head (1aad5f3).

Files with missing lines Patch % Lines
...in/kotlin/com/wire/android/model/UserAvatarData.kt 0.00% 5 Missing ⚠️
...ion/create/overview/CreateAccountOverviewParams.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3657      +/-   ##
=====================================================
- Coverage              45.34%   45.33%   -0.02%     
=====================================================
  Files                    471      471              
  Lines                  15842    15848       +6     
  Branches                2655     2656       +1     
=====================================================
  Hits                    7184     7184              
- Misses                  7885     7891       +6     
  Partials                 773      773              
Files with missing lines Coverage Δ
...ion/create/overview/CreateAccountOverviewParams.kt 0.00% <0.00%> (ø)
...in/kotlin/com/wire/android/model/UserAvatarData.kt 31.81% <0.00%> (-9.36%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a791bf...1aad5f3. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Contributor

Built wire-android-staging-compat-pr-3657.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3657.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 26, 2024
Merged via the queue into release/candidate with commit b5ec027 Nov 26, 2024
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the fix/accessibility_strings_founded_issues branch November 26, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants