fix: Accessibility strings founded issues #WPB-9784 🍒 #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
saleniuk
reviewed
Nov 26, 2024
app/src/main/kotlin/com/wire/android/ui/common/avatar/UserProfileAvatar.kt
Outdated
Show resolved
Hide resolved
borichellow
approved these changes
Nov 27, 2024
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3667 +/- ##
===========================================
- Coverage 46.11% 46.09% -0.02%
===========================================
Files 472 472
Lines 16140 16146 +6
Branches 2674 2675 +1
===========================================
Hits 7443 7443
- Misses 7919 7925 +6
Partials 778 778
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3667.apk is available for download |
|
Built wire-android-dev-debug-pr-3667.apk is available for download |
damian-kaczmarek
approved these changes
Nov 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
borichellow
deleted the
fix/accessibility_strings_founded_issues-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
While testing accessibility strings Astrid found some small issues in ConversationsList ConversationDetails and SelfProfile screens.
Solutions
Fix the issues