Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: externalize all wire links to support custom builds (WPB-9811) #3158

Merged
merged 11 commits into from
Jul 4, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 3, 2024

BugWPB-9811 [Android] - C1, C2, C3 related Links are outdated- add new links as below - on Custom builds


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

For custom builds, we need to support external URLs not necessary into the wire website.

Causes (Optional)

Not supported / Out of initial scope

Solutions

  • Move URLs to urls.xml file, so external builds can have their own if necessary.
  • Fixes some URLs that were localized, this is not necessary since wire portal handles this according to the browser locale.

Note

Most of the changes are removing entries from strings resources, this can be ignored to have a better review.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Jul 3, 2024
@yamilmedina yamilmedina changed the title chore: externalize all wire links to support custom builds (WPB-9811) chore: externalize all wire links to support custom builds (WPB-5512) Jul 3, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 3, 2024
@yamilmedina yamilmedina requested review from MohamadJaara, alexandreferris, saleniuk, a team, typfel and borichellow and removed request for a team July 3, 2024 15:14
@yamilmedina yamilmedina closed this Jul 3, 2024
@yamilmedina yamilmedina reopened this Jul 3, 2024
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 3, 2024
@yamilmedina yamilmedina requested a review from vitorhugods July 3, 2024 15:50
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Test Results

857 tests   857 ✅  9m 9s ⏱️
117 suites    0 💤
117 files      0 ❌

Results for commit 2be48b7.

♻️ This comment has been updated with latest results.

~ You should have received a copy of the GNU General Public License
~ along with this program. If not, see http://www.gnu.org/licenses/.
-->
<resources>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the links be easier to customize if we add them to the default.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I was talking yesterday with @vitorhugods, and we might not even need this file for public app.

We can just create an url.xml file in the specific builds resources directory, and the resource key will be overriden, so I think they are easy to customize with this approach or default json the same way. Just less Gradle config with this approach.

@yamilmedina yamilmedina changed the title chore: externalize all wire links to support custom builds (WPB-5512) chore: externalize all wire links to support custom builds (WPB-9811) Jul 4, 2024
Copy link

sonarqubecloud bot commented Jul 4, 2024

Copy link
Contributor

github-actions bot commented Jul 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina merged commit f164164 into release/cycle-4.6 Jul 4, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the chore/links-for-custombuilds branch July 4, 2024 14:36
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 16, 2024
@b1pb1p b1pb1p added echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants