-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: externalize all wire links to support custom builds (WPB-9811) #3158
Conversation
Test Results857 tests 857 ✅ 9m 9s ⏱️ Results for commit 2be48b7. ♻️ This comment has been updated with latest results. |
app/src/main/res/values/urls.xml
Outdated
~ You should have received a copy of the GNU General Public License | ||
~ along with this program. If not, see http://www.gnu.org/licenses/. | ||
--> | ||
<resources> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will the links be easier to customize if we add them to the default.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I was talking yesterday with @vitorhugods, and we might not even need this file for public app.
We can just create an url.xml
file in the specific builds resources directory, and the resource key
will be overriden, so I think they are easy to customize with this approach or default json
the same way. Just less Gradle config with this approach.
Quality Gate passedIssues Measures |
APKs built during tests are available here. Scroll down to Artifacts! |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
For custom builds, we need to support external URLs not necessary into the wire website.
Causes (Optional)
Not supported / Out of initial scope
Solutions
urls.xml
file, so external builds can have their own if necessary.Note
Most of the changes are removing entries from strings resources, this can be ignored to have a better review.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.