-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: externalize all wire links to support custom builds (WPB-9811) 🍒 #3160
Merged
yamilmedina
merged 4 commits into
release/candidate
from
chore/links-for-custombuilds-cherry-pick
Jul 5, 2024
Merged
chore: externalize all wire links to support custom builds (WPB-9811) 🍒 #3160
yamilmedina
merged 4 commits into
release/candidate
from
chore/links-for-custombuilds-cherry-pick
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
changed the title
chore: externalize all wire links to support custom builds (WPB-9811) 🍒
chore: externalize all wire links to support custom builds 🍒
Jul 4, 2024
yamilmedina
changed the title
chore: externalize all wire links to support custom builds 🍒
chore: externalize all wire links to support custom builds (WPB-9811) 🍒
Jul 4, 2024
saleniuk
approved these changes
Jul 5, 2024
MohamadJaara
approved these changes
Jul 5, 2024
Test Results12 tests 12 ✅ 0s ⏱️ Results for commit b422540. |
Quality Gate passedIssues Measures |
6 tasks
APKs built during tests are available here. Scroll down to Artifacts! |
echoes-hq
bot
added
the
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
label
Jul 16, 2024
b1pb1p
added
echoes: technical-roadmap/throughput
More specific category, to highlight task aiming at improving the development velocity and effici...
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
and removed
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
labels
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
echoes: technical-roadmap/throughput
More specific category, to highlight task aiming at improving the development velocity and effici...
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
For custom builds, we need to support external URLs not necessary into the wire website.
Causes (Optional)
Not supported / Out of initial scope
Solutions
urls.xml
file, so external builds can have their own if necessary.Note
Most of the changes are removing entries from strings resources, this can be ignored to have a better review.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.