fix: App crash on app unlock with fingerprint (WPB-5110) (WPB-5108)

app/src/main/kotlin/com/wire/android/biomitric/BiometricPromptUtils.kt

@@ -43,7 +43,7 @@ object BiometricPromptUtils {
             override fun onAuthenticationError(errorCode: Int, errorString: CharSequence) {
                 super.onAuthenticationError(errorCode, errorString)
                 appLogger.i("$TAG errorCode is $errorCode and errorString is: $errorString")
-                if (errorCode == ERROR_NEGATIVE_BUTTON) {
+                if (errorCode == ERROR_NEGATIVE_BUTTON || errorCode == BiometricPrompt.ERROR_LOCKOUT) {
                     onRequestPasscode()
                 } else {
                     onCancel()
@@ -78,16 +78,15 @@ fun AppCompatActivity.showBiometricPrompt(
     onCancel: () -> Unit,
     onRequestPasscode: () -> Unit
 ) {
-    appLogger.i("$TAG showing biometrics dialog...")
-
     val canAuthenticate = BiometricManager.from(this)
         .canAuthenticate(BiometricManager.Authenticators.BIOMETRIC_STRONG)
     if (canAuthenticate == BiometricManager.BIOMETRIC_SUCCESS) {
+        appLogger.i("$TAG showing biometrics dialog...")
         val biometricPrompt = BiometricPromptUtils.createBiometricPrompt(
-            this,
-            onSuccess,
-            onCancel,
-            onRequestPasscode,
+            activity = this,
+            onSuccess = onSuccess,
+            onCancel = onCancel,
+            onRequestPasscode = onRequestPasscode
         )
         val promptInfo = BiometricPromptUtils.createPromptInfo(this)
         biometricPrompt.authenticate(promptInfo)

app/src/main/kotlin/com/wire/android/ui/WireActivity.kt

@@ -30,6 +30,7 @@
 import androidx.activity.viewModels
 import androidx.appcompat.app.AppCompatActivity
 import androidx.biometric.BiometricManager
+import androidx.biometric.BiometricManager.Authenticators.BIOMETRIC_STRONG
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.statusBarsPadding
 import androidx.compose.material3.SnackbarHostState
@@ -40,7 +41,6 @@
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
-import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.runtime.rememberUpdatedState
 import androidx.compose.runtime.setValue
 import androidx.compose.runtime.staticCompositionLocalOf
@@ -49,7 +49,10 @@
 import androidx.compose.ui.platform.LocalSoftwareKeyboardController
 import androidx.core.splashscreen.SplashScreen.Companion.installSplashScreen
 import androidx.core.view.WindowCompat
+import androidx.lifecycle.Lifecycle
+import androidx.lifecycle.flowWithLifecycle
 import androidx.lifecycle.lifecycleScope
+import androidx.lifecycle.repeatOnLifecycle
 import androidx.navigation.NavController
 import androidx.navigation.NavHostController
 import com.ramcosta.composedestinations.spec.Route
@@ -93,12 +96,9 @@
 import com.wire.android.util.deeplink.DeepLinkResult
 import com.wire.android.util.ui.updateScreenSettings
 import dagger.hilt.android.AndroidEntryPoint
-import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.collectLatest
 import kotlinx.coroutines.flow.filter
-import kotlinx.coroutines.flow.launchIn
-import kotlinx.coroutines.flow.onEach
 import kotlinx.coroutines.flow.onSubscription
 import kotlinx.coroutines.launch
 import javax.inject.Inject
@@ -170,7 +170,6 @@
                     Column(modifier = Modifier.statusBarsPadding()) {
                         ReportDrawnWhen { isLoaded }
                         val navigator = rememberNavigator(this@WireActivity::finish)
-                        val scope = rememberCoroutineScope()
                         CommonTopAppBar(
                             connectivityUIState = commonTopAppBarViewModel.connectivityState,
                             onReturnToCallClick = { establishedCall ->
@@ -184,7 +183,7 @@
 
                         // This setup needs to be done after the navigation graph is created, because building the graph takes some time,
                         // and if any NavigationCommand is executed before the graph is fully built, it will cause a NullPointerException.
-                        setUpNavigation(navigator.navController, onComplete, scope)
+                        setUpNavigation(navigator.navController, onComplete)
                         isLoaded = true
                         handleScreenshotCensoring()
                         handleAppLock(navigator::navigate)
@@ -199,17 +198,20 @@
     private fun setUpNavigation(
         navController: NavHostController,
         onComplete: () -> Unit,
-        scope: CoroutineScope
     ) {
         val currentKeyboardController by rememberUpdatedState(LocalSoftwareKeyboardController.current)
         val currentNavController by rememberUpdatedState(navController)
-        LaunchedEffect(scope) {
-            navigationCommands
-                .onSubscription { onComplete() }
-                .onEach { command ->
-                    currentKeyboardController?.hide()
-                    currentNavController.navigateToItem(command)
-                }.launchIn(scope)
+        LaunchedEffect(Unit) {
+            lifecycleScope.launch {
+                repeatOnLifecycle(Lifecycle.State.STARTED) {
+                    navigationCommands
+                        .onSubscription { onComplete() }
+                        .collectLatest {
+                            currentKeyboardController?.hide()
+                            currentNavController.navigateToItem(it)
+                        }
+                }
+            }
         }
 
         DisposableEffect(navController) {
@@ -241,19 +243,22 @@
     @Composable
     private fun handleAppLock(navigate: (NavigationCommand) -> Unit) {
         LaunchedEffect(Unit) {
-            lockCodeTimeManager.isLocked()
-                .filter { it }
-                .collectLatest {
-                    val canAuthenticateWithBiometrics = BiometricManager
-                        .from(this@WireActivity)
-                        .canAuthenticate(BiometricManager.Authenticators.BIOMETRIC_STRONG)
-
-                    if (canAuthenticateWithBiometrics == BiometricManager.BIOMETRIC_SUCCESS) {
-                        navigate(NavigationCommand(AppUnlockWithBiometricsScreenDestination, BackStackMode.UPDATE_EXISTED))
-                    } else {
-                        navigate(NavigationCommand(EnterLockCodeScreenDestination, BackStackMode.UPDATE_EXISTED))
+            lifecycleScope.launch {
+                // Listen to one flow in a lifecycle-aware manner using flowWithLifecycle
+                lockCodeTimeManager.isLocked()
+                    .flowWithLifecycle(lifecycle, Lifecycle.State.STARTED)
+                    .filter { it }
+                    .collectLatest {
+                        val canAuthenticateWithBiometrics = BiometricManager
+                            .from(this@WireActivity)
+                            .canAuthenticate(BIOMETRIC_STRONG)
+                        if (canAuthenticateWithBiometrics == BiometricManager.BIOMETRIC_SUCCESS) {
+                            navigate(NavigationCommand(AppUnlockWithBiometricsScreenDestination, BackStackMode.UPDATE_EXISTED))
+                        } else {
+                            navigate(NavigationCommand(EnterLockCodeScreenDestination, BackStackMode.UPDATE_EXISTED))
+                        }
                     }
-                }
+            }
         }
     }