-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: App crash on app unlock with fingerprint (WPB-5110) (WPB-5108) #2348
Conversation
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/WireActivity.kt
Codecov Report
@@ Coverage Diff @@
## develop #2348 +/- ##
=============================================
- Coverage 41.21% 41.19% -0.03%
Complexity 1058 1058
=============================================
Files 335 335
Lines 12059 12065 +6
Branches 1595 1595
=============================================
Hits 4970 4970
- Misses 6614 6620 +6
Partials 475 475
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1428 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Causes (Optional)
After 5 failed attempts of auth with biometrics, the system will lock out the biometrics API and will return an error which we were not handling it.
The app was emitting the screen to go when it's in the background causing a failure when showing biometrics prompt.
Unable to start authentication. Called after onSaveInstanceState()
Solutions
handle that error by navigating the user to passcode screen
Make flow observation lifecycle aware so the app will stop emitting/observing when it's in background. Also this way the app will prevent resource wasting.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.