Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app lock UI and UX adjustments [WPB-4695] #2335

Merged
merged 17 commits into from
Oct 18, 2023

Merge remote-tracking branch 'origin/develop' into feat/applock_ui_ad…

c60413e
Select commit
Loading
Failed to load commit list.
Merged

feat: app lock UI and UX adjustments [WPB-4695] #2335

Merge remote-tracking branch 'origin/develop' into feat/applock_ui_ad…
c60413e
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 18, 2023 in 0s

41.21% (-0.04%) compared to 4bcd746

View this Pull Request on Codecov

41.21% (-0.04%) compared to 4bcd746

Details

Codecov Report

Merging #2335 (c60413e) into develop (4bcd746) will decrease coverage by 0.04%.
Report is 2 commits behind head on develop.
The diff coverage is 13.75%.

@@              Coverage Diff              @@
##             develop    #2335      +/-   ##
=============================================
- Coverage      41.24%   41.21%   -0.04%     
  Complexity      1058     1058              
=============================================
  Files            332      335       +3     
  Lines          12032    12059      +27     
  Branches        1594     1595       +1     
=============================================
+ Hits            4963     4970       +7     
- Misses          6594     6614      +20     
  Partials         475      475              
Files Coverage Δ
...ire/android/ui/home/appLock/LockCodeTimeManager.kt 90.90% <100.00%> (+1.62%) ⬆️
...re/android/ui/home/appLock/SetLockCodeViewState.kt 100.00% <100.00%> (ø)
...ns/details/options/GroupConversationOptionsItem.kt 0.00% <ø> (ø)
...d/ui/home/settings/privacy/PrivacySettingsState.kt 0.00% <ø> (ø)
...ire/android/feature/ObserveAppLockConfigUseCase.kt 90.90% <66.66%> (+0.90%) ⬆️
...on/create/details/CreateAccountDetailsViewModel.kt 0.00% <0.00%> (ø)
...ectedGuestLink/CreatePasswordGuestLinkViewModel.kt 87.50% <0.00%> (ø)
.../home/settings/privacy/PrivacySettingsViewModel.kt 0.00% <0.00%> (ø)
...com/wire/android/ui/home/settings/SettingsState.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc76aae...c60413e. Read the comment docs.