Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: app lock UI and UX adjustments [WPB-4695] #2335

Merged
merged 17 commits into from
Oct 18, 2023
Merged

feat: app lock UI and UX adjustments [WPB-4695] #2335

merged 17 commits into from
Oct 18, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Oct 16, 2023 •
edited by github-actions bot
Loading

StoryWPB-4695 [Android] Toggle app lock from the app settings (Password only)

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • ConversationOptionSwitch extracted and renamed to SettingsOptionSwitch for easier reusability
  • added new type of SettingsItem to allow adding also rows that contain switch
  • moved app lock options from PrivacySettings to global Settings under “App Settings” group
  • added TurnAppLockOffDialog for the user to confirm that he/she wants to turn off the app lock
  • implemented logic to show which particular passlock requirements are missing
  • adjusted UI according to current designs of “set app lock” and “enter app lock”

Dependencies (Optional)

Needs releases with:

Testing

How to Test

Open settings and set the app lock, kill the app and open again to see enter the app lock screen.

Attachments (Optional)

Before After   
settings_before settings_after
set_passcode_before set_passcode_after
enter_passcode_before enter_passcode_after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Test Results

649 tests   649 ✔️  8m 18s ⏱️
  94 suites      0 💤
  94 files        0 ❌

Results for commit c60413e.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1350 failed.

@AndroidBob
Copy link
Collaborator

Build 1352 failed.

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #2335 (c60413e) into develop (4bcd746) will decrease coverage by 0.04%.
Report is 2 commits behind head on develop.
The diff coverage is 13.75%.

@@              Coverage Diff              @@
##             develop    #2335      +/-   ##
=============================================
- Coverage      41.24%   41.21%   -0.04%     
  Complexity      1058     1058              
=============================================
  Files            332      335       +3     
  Lines          12032    12059      +27     
  Branches        1594     1595       +1     
=============================================
+ Hits            4963     4970       +7     
- Misses          6594     6614      +20     
  Partials         475      475
Files Coverage Δ
...ire/android/ui/home/appLock/LockCodeTimeManager.kt 90.90% <100.00%> (+1.62%) ⬆️
...re/android/ui/home/appLock/SetLockCodeViewState.kt 100.00% <100.00%> (ø)
...ns/details/options/GroupConversationOptionsItem.kt 0.00% <ø> (ø)
...d/ui/home/settings/privacy/PrivacySettingsState.kt 0.00% <ø> (ø)
...ire/android/feature/ObserveAppLockConfigUseCase.kt 90.90% <66.66%> (+0.90%) ⬆️
...on/create/details/CreateAccountDetailsViewModel.kt 0.00% <0.00%> (ø)
...ectedGuestLink/CreatePasswordGuestLinkViewModel.kt 87.50% <0.00%> (ø)
.../home/settings/privacy/PrivacySettingsViewModel.kt 0.00% <0.00%> (ø)
...com/wire/android/ui/home/settings/SettingsState.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc76aae...c60413e. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1361 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, gongracr, yamilmedina and borichellow and removed request for a team October 17, 2023 17:51
@AndroidBob
Copy link
Collaborator

Build 1384 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
d5bd000e14c50b23fa1622c5ff27184403987aa3 c82d8aa7757ddb2b22c6ded6120daed6e2c35a2a

Is this intentional?

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1394 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Oct 18, 2023
Merged via the queue into develop with commit ab9e3dd Oct 18, 2023
12 checks passed
@saleniuk saleniuk deleted the feat/applock_ui_adjustments branch October 18, 2023 12:05
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohassine ohassine ohassine approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@yamilmedina yamilmedina Awaiting requested review from yamilmedina yamilmedina was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@saleniuk saleniuk

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saleniuk @AndroidBob @alexandreferris @ohassine