fix: sub conversation epoch verification [WPB-15647]

[Garzas]

WPB-15647 [Android] epoch check for sub conversations is verifying the main conversation

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

The previous implementation did not handle epoch verification for sub-conversations. As a result, the verification process always checked the parent conversation's epoch, leading to incorrect behavior when the sub-conversation epoch was out of sync while the parent conversation's epoch remained valid.

Causes

1. Lack of Sub-Conversation Handling: Sub-conversations were not considered during epoch verification.
2. Missing Models and Logic: There were no models or logic in place to support sub-conversation-specific checks.
3. Incorrect Parent Conversation Focus: Epoch verification defaulted to the parent conversation, ignoring sub-conversations entirely.

Solutions

1. Added verifySubConversationEpoch:

   • A dedicated method to verify epochs for sub-conversations, ensuring accurate context for verification.

2. Sub-Conversation Repository Arrangement:

   • Created SubconversationRepositoryArrangement to mock and test sub-conversation-related methods efficiently.

3. Introduced Sub-Conversation Models:

   • Added models in the logic module to handle sub-conversations as first-class entities.

4. Updated Epoch Verification Logic:

   • Refactored NewMessageEventHandler to call verifySubConversationEpoch when a subConversationId is provided.

5. Added Comprehensive Tests:

   • Verified that fetchConversation is not called when a subConversationId is present.
   • Ensured correct behavior for valid epochs, stale epochs, and failures.

[github-actions]

Test Results

3 353 tests  +5   3 245 ✅ +5   5m 41s ⏱️ +27s
  572 suites ±0     108 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit bdec069. ± Comparison against base commit b471e2a.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

Branch report: fix/subconversation-epoch-verifier
Commit report: ca7e851
Test service: kalium-jvm

✅ 0 Failed, 3245 Passed, 108 Skipped, 1m 0.71s Total Time

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 45.61404% with 31 lines in your changes missing coverage. Please review.

Project coverage is 54.51%. Comparing base (b471e2a) to head (bdec069).

Files with missing lines	Patch %	Lines
.../kalium/logic/data/conversation/SubConversation.kt	0.00%	12 Missing ⚠️
...m/logic/data/conversation/SubConversationMapper.kt	0.00%	12 Missing ⚠️
...gic/data/conversation/SubconversationRepository.kt	0.00%	3 Missing ⚠️
...authenticated/conversation/ConversationResponse.kt	0.00%	2 Missing ⚠️
...c/data/conversation/LeaveSubconversationUseCase.kt	0.00%	0 Missing and 1 partial ⚠️
.../kotlin/com/wire/kalium/logic/data/id/IdMappers.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           release/candidate    #3244      +/-   ##
=====================================================
- Coverage              54.52%   54.51%   -0.02%     
=====================================================
  Files                   1250     1252       +2     
  Lines                  36555    36605      +50     
  Branches                3699     3702       +3     
=====================================================
+ Hits                   19932    19954      +22     
- Misses                 15222    15250      +28     
  Partials                1401     1401              

Files with missing lines	Coverage Δ
...kalium/logic/feature/message/StaleEpochVerifier.kt	100.00% <100.00%> (ø)
...ver/conversation/message/NewMessageEventHandler.kt	84.76% <100.00%> (+0.14%)	⬆️
...c/data/conversation/LeaveSubconversationUseCase.kt	82.14% <0.00%> (ø)
.../kotlin/com/wire/kalium/logic/data/id/IdMappers.kt	93.33% <0.00%> (-6.67%)	⬇️
...authenticated/conversation/ConversationResponse.kt	0.00% <0.00%> (ø)
...gic/data/conversation/SubconversationRepository.kt	0.00% <0.00%> (ø)
.../kalium/logic/data/conversation/SubConversation.kt	0.00% <0.00%> (ø)
...m/logic/data/conversation/SubConversationMapper.kt	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b471e2a...bdec069. Read the comment docs.