fix: sub conversation epoch verification [WPB-15647] 🍒 #3247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
The previous implementation did not handle epoch verification for sub-conversations. As a result, the verification process always checked the parent conversation's epoch, leading to incorrect behavior when the sub-conversation epoch was out of sync while the parent conversation's epoch remained valid.
Causes
Solutions
Added
verifySubConversationEpoch
:Sub-Conversation Repository Arrangement:
SubconversationRepositoryArrangement
to mock and test sub-conversation-related methods efficiently.Introduced Sub-Conversation Models:
logic
module to handle sub-conversations as first-class entities.Updated Epoch Verification Logic:
NewMessageEventHandler
to callverifySubConversationEpoch
when asubConversationId
is provided.Added Comprehensive Tests:
fetchConversation
is not called when asubConversationId
is present.