Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cherry-pick): try catch shared pref creation on android #2169

Merged

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherry-pick of #2013


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

* fix: try catch Exceptions when initializing encrypted shared pref

* ignore the test

* revert unwanted change

* detekt
@tmspzz tmspzz enabled auto-merge (squash) October 25, 2023 09:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Unit Test Results

   412 files     412 suites   22s ⏱️
2 262 tests 2 142 ✔️ 120 💤 0

Results for commit 3640dff.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/try-catch-shared-pref-creation-on-android
Commit report: 4a07145

kalium-jvm: 0 Failed, 0 New Flaky, 2259 Passed, 98 Skipped, 10m 39s Wall Time

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@51abd95). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2169   +/-   ##
====================================================
  Coverage                     ?   58.16%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1010           
  Lines                        ?    37721           
  Branches                     ?     3434           
====================================================
  Hits                         ?    21939           
  Misses                       ?    14311           
  Partials                     ?     1471           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51abd95...3640dff. Read the comment docs.

@tmspzz tmspzz merged commit 7603587 into release/candidate Oct 25, 2023
13 checks passed
@tmspzz tmspzz deleted the fix/try-catch-shared-pref-creation-on-android branch October 25, 2023 10:20
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
* fix: try catch Exceptions when initializing encrypted shared pref

* ignore the test

* revert unwanted change

* detekt

Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants