Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cherry-pick): try catch shared pref creation on android #2170

Closed
wants to merge 1 commit into from
Closed

fix(cherry-pick): try catch shared pref creation on android #2170

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherry-pick of #2013

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine @MohamadJaara @github-actions
fix: try catch shared pref creation on android (#2013) (#2169)
dfe8d3f 
* fix: try catch Exceptions when initializing encrypted shared pref

* ignore the test

* revert unwanted change

* detekt

Co-authored-by: Mohamad Jaara <[email protected]>
@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Oct 25, 2023
@ohassine ohassine closed this Oct 25, 2023
@tmspzz tmspzz deleted the fix/try-catch-shared-pref-creation-on-android-cherry-pick branch February 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ohassine ohassine

Labels
cherry-pick PR is cherry-picking changes from another banch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ohassine