feat: extended password verification #2134
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2134 +/- ##
=============================================
+ Coverage 57.63% 57.64% +0.01%
Complexity 24 24
=============================================
Files 1031 1031
Lines 38704 38719 +15
Branches 3519 3522 +3
=============================================
+ Hits 22306 22321 +15
Misses 14896 14896
Partials 1502 1502
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
saleniuk
requested review from
a team,
alexandreferris,
MohamadJaara,
vitorhugods,
mchenani and
Garzas
and removed request for
a team
| val missingLowercaseCharacter: Boolean = true, | ||
| val missingUppercaseCharacter: Boolean = true, | ||
| val missingDigit: Boolean = true, | ||
| val missingSpecialCharacter: Boolean = true, | ||
| val tooShort: Boolean = true, |
There was a problem hiding this comment.
thought: maybe use a Set<Criteria> instead of multiple fields.
For example:
enum class Criteria {
LOWERCASE, UPPERCASE, NUMERIC_DIGIT, SPECIAL_CHARACTER, MINIMUM_LENGTH;
}
sealed interface ValidatePasswordResult {
data object Valid: ValidatePasswordResult()
data class Invalid(val missingCriteria: Set<Criteria>)
}In any case, not something I'd change now that it's done. Just food for thought really. Aiming to make the API a tiny bit more scalable.
…word_verification
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
…word_verification
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Currently we can only verify if the whole password is valid or not, but some screens require to show which elements are still missing (like "one uppercase character").
Solutions
Change the use case to return the sealed class where
Invalidcontains multiple fields to know exactly which elements are still missing in the password.Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.